Skip to content

Forbid this.skip() within afterAll hooks #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 3, 2020
Merged

Forbid this.skip() within afterAll hooks #4136

merged 3 commits into from
Jan 3, 2020

Conversation

@juergba
Copy link
Contributor

@juergba juergba commented Jan 1, 2020

Description of the Change

  • remove deprecation message
  • fail after hook with ERR_MOCHA_UNSUPPORTED error

@juergba juergba added status: needs review a maintainer should (re-)review this pull request semver-major implementation requires increase of "major" version number; "breaking changes" type: cleanup a refactor labels Jan 1, 2020
@juergba juergba self-assigned this Jan 1, 2020
@coveralls
Copy link

coveralls commented Jan 1, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 92.814% when pulling 6fd22f2 on juergba/skip-afterall into 24c22be on master.

@juergba juergba added type: feature enhancement proposal and removed type: cleanup a refactor labels Jan 2, 2020
@juergba juergba force-pushed the juergba/skip-afterall branch from 87cc74f to ed4aa6d Compare January 3, 2020 08:35
craigtaub
craigtaub approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@craigtaub craigtaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juergba juergba force-pushed the juergba/skip-afterall branch from ed4aa6d to 6fd22f2 Compare January 3, 2020 15:27
@juergba juergba added this to the v7.0.0 milestone Jan 3, 2020
@juergba juergba removed the status: needs review a maintainer should (re-)review this pull request label Jan 3, 2020
@juergba juergba changed the title Forbid this.skip() within afterall hooks Forbid this.skip() within afterAll hooks Jan 3, 2020
@juergba juergba merged commit 3bd2d28 into master Jan 3, 2020
@juergba juergba deleted the juergba/skip-afterall branch January 3, 2020 16:35
@juergba juergba mentioned this pull request Feb 29, 2020
Closed
@mfranzke mfranzke mentioned this pull request Mar 12, 2023
Draft
76 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@outsideris outsideris Awaiting requested review from outsideris

@boneskull boneskull Awaiting requested review from boneskull

1 more reviewer

@craigtaub craigtaub craigtaub approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@juergba juergba

Labels

semver-major implementation requires increase of "major" version number; "breaking changes" type: feature enhancement proposal

Projects

None yet

Milestone

v7.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@juergba @coveralls @craigtaub