-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add reporter alias names to docs #4127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@khg0712 Your email for git commit is not connected your GitHub account. |
|
@outsideris I changed it! |
juergba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khg0712 thank you for this PR. I have some small comments.
juergba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess something went wrong while resolving conflicts.
I propose:
- delete your last commits
git reset ... - to keep up with
master, don't merge but rebasegit rebase ... - then apply your changes and be careful when resolving conflicts.
I don't see any problem, IMO this list is perfect as it is. |
doesn't it needs to specify all alias like |
|
No, HTML is the default reporter for Mocha browser and should not show up in this CLI listing. |
|
sry, I cited wrong example.
I meant that it seems to need to be added capitalized alias to cli options. |
|
I have understood your concerns, but this listing is good as is, please leave it unchanged. |
juergba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khg0712 thank you

Description
Description of the Change
Summary
before
The "progress" reporter implements a simple progress-bar:
after
Enable Names:
Progress,progressThe Progress reporter implements a simple progress-bar:
fix #4054
fix #4134