Skip to content

Hide stacktrace when cli args are missing #3963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craigtaub merged 3 commits into from
Jul 17, 2019
Merged

Hide stacktrace when cli args are missing #3963

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
100a42f
hide stacktrace when cli args is missing
outsideris Jun 29, 2019
76b1687
Update lib/cli/options.js
outsideris Jul 16, 2019
775f542
remove unused lines
outsideris Jul 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/cli/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
*/

const fs = require('fs');
const ansi = require('ansi-colors');
const yargsParser = require('yargs-parser');
const {types, aliases} = require('./run-option-metadata');
const {ONE_AND_DONE_ARGS} = require('./one-and-dones');
Expand All @@ -16,7 +17,6 @@ const {loadConfig, findConfig} = require('./config');
const findUp = require('find-up');
const {deprecate} = require('../utils');
const debug = require('debug')('mocha:cli:options');
const {createMissingArgumentError} = require('../errors');
const {isNodeFlag} = require('./node-flags');

/**
Expand Down Expand Up @@ -131,7 +131,8 @@ const parse = (args = [], defaultValues = {}, ...configObjects) => {
boolean: types.boolean.concat(nodeArgs.map(pair => pair[0]))
});
if (result.error) {
throw createMissingArgumentError(result.error.message);
console.error(ansi.red(`Error: ${result.error.message}`));
process.exit(1);
}

// reapply "=" arg values from above
Expand Down