Test output order has changed: test result shown after `afterEach` hook output

[juergba]

Prerequisites

• Checked that your issue hasn't already been filed by cross-referencing issues with the faq label
• Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in your code.
• 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself
• Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with: node node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend avoiding the use of globally installed Mocha.

Description

The output of the testfile cascade.fixture.js has changed compared to my local V5.2.0. The order of hook execution remains correct.

Output of master branch:

one
before one
    two
  before two
      three
    before three
  before each one
    before each two
    before each three
      TEST three
    after each three
    after each two
  after each one
        √ should three                            <<<<< different
    after three
  after two
after one

Output of my local Mocha installation V5.2.0:

one
before one
    two
  before two
      three
    before three
  before each one
    before each two
    before each three
      TEST three
        √ should three
    after each three
    after each two
  after each one
    after three
  after two
after one

Steps to Reproduce

Expected behavior: as shown in second output

Actual behavior: as shown in first output

Reproduces how often: always

Versions

• The output of mocha --version and node node_modules/.bin/mocha --version: 5.2.0
• The output of node --version: 10.5.0
• The version and architecture of your operating system: Windows 10 Home, 1809
• Your shell (bash, zsh, PowerShell, cmd, etc.): cmd of VSCode
• Your browser and version (if running browser tests):
• Any other third party Mocha related modules (with versions):
• The code transpiler being used: none

Additional Information

[plroebuck]

Need to know the last commit done to the "master" branch you have checked out...

$ git checkout master
$ git show --oneline -s

[juergba]

D:\mocha3291\mocha>git show --oneline -s
593e9b8 (HEAD -> master, origin/master, origin/HEAD) Add ability to query Mocha version programmatically (#3535)

[plroebuck]

I glanced through the commits, but nothing popped out at me. We will have to create a test that verifies the exact expected order, then checkout commits since 5.2.0 (jumping by half each time), add the test manually, and retest until one of them fails.

[juergba]

I checked-out the commits:

• 02294a3: 11. August - fix report in a case of afterEach conditional fail
• 2bb4124: 07. August - resolves Links for Code of Conduct in MAINTAINERS.md lead to CHANGELOG.md #3450: changed links labeled "code of conduct" from changelo

The first commit fails, while using above testfile.