`Runner#fail` is getting executed with an instance of `Pending`

[dasilvacontin]

code smell: #946 (comment)

mocha/lib/runner.js

Lines 221 to 234 in 8a37e01

	Runner.prototype.fail = function(test, err) {
	++this.failures;
	test.state = 'failed';
	if (!(err instanceof Error || err && typeof err.message === 'string')) {
	err = new Error('the ' + type(err) + ' ' + stringify(err) + ' was thrown, throw an Error :)');
	}
	err.stack = (this.fullStackTrace || !err.stack)
	? err.stack
	: stackFilter(err.stack);
	this.emit('fail', test, err);
	};

[dasilvacontin]

The test shouldn't be marked as failed when the thrown Error is what we use to indicate a Pending test.

[ScottFreeCode]

Re. #2335 (comment): we also have #2228 re. the relationship of Pending and Error. However, merely changing Pending to extend Error would in this case presumably result in it being processed through the fail function as though it were a regular error, which wouldn't be correct either... am I right about that?

[boneskull]

Oh, hm. Well, Pending isn't a failure, but it is intended to abort the test. I don't think it should be marked "failed", but as long as reporters don't know about it, I don't see it being a urgent issue, right?

[dasilvacontin]

I hadn't seen #2228 – thanks for the ref, @ScottFreeCode!

Not urgent, but I'm somewhat curious about this one.

[boneskull]

@dasilvacontin Runner.prototype.fail() doesn't seem to actually get executed when something is skipped via this.skip(). Did you observe this?

[dasilvacontin]

Yes, in my trivial async skip example. Or at least I did get the exception when I wrote the comment.

On 01 Jul 2016, at 08:41, Christopher Hiller notifications@github.com wrote:

@dasilvacontin Runner.prototype.fail() doesn't seem to actually get executed when something is skipped via this.skip(). Did you observe this?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[stale]

I am a bot that watches issues for inactivity.
This issue hasn't had any recent activity, and I'm labeling it stale. In 14 days, if there are no further comments or activity, I will close this issue.
Thanks for contributing to Mocha!

[stale]

I am a bot that watches issues for inactivity.
This issue hasn't had any recent activity, and I'm labeling it stale. In 14 days, if there are no further comments or activity, I will close this issue.
Thanks for contributing to Mocha!