mount: test nitpicks #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Do not ignore errors from Mkdir. 2. Use ioutil.WriteFile for simplicity, to not leak fds and to not ignore errors from Write or Close. Signed-off-by: Kir Kolyshkin <[email protected]>
The mount option `relatime` can be added by the kernel, and this is what happens on my machine: > --- FAIL: TestMount (0.00s) > mounter_linux_test.go:176: unexpected mount option "relatime", expected "" > FAIL Same as in commit afc7b0d, this option should be ignored. Signed-off-by: Kir Kolyshkin <[email protected]>
Collaborator
Author
|
@cpuguy83 @thaJeztah PTAL |
Member
|
could you add CI so that tests actually run on this repo? probably could just copy what's in https://github.com/moby/term/blob/master/.github/workflows/test.yml |
Collaborator
Author
|
I plan to add CI once #3 is merged (don't remember ATM why it's needed but it's needed) |
Collaborator
Author
|
merging to unblock adding CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mount: fix test for added relatime
The mount option
relatimecan be added by the kernel, andthis is what happens on my machine:
Same as in commit afc7b0d, this option should be ignored.
mount: test nitpicks
ignore errors from Write or Close.