Add support for Seccomp and AppArmor profiles. #3152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3152 +/- ##
==========================================
+ Coverage 61.67% 61.79% +0.11%
==========================================
Files 155 155
Lines 31143 31143
==========================================
+ Hits 19207 19244 +37
+ Misses 10389 10346 -43
- Partials 1547 1553 +6 |
thaJeztah
reviewed
Aug 11, 2023
api/types.proto
Outdated
Comment on lines
1160
to
1167
| // Apparmor is the Apparmor profile to be applied to the container, if any. | ||
| // The node running the container must have the profile present. | ||
| string apparmor = 3; | ||
|
|
||
| // Seccomp is the seccomp profile to be used as a seccomp filter for the | ||
| // container, or "unconfined" if none. The profile must be present on the | ||
| // node running the container. | ||
| string seccomp = 4; |
Member
There was a problem hiding this comment.
Perhaps make it explicit; apparmor_profile and seccomp_profile ?
dperny
force-pushed
the
add-seccomp-apparmor
branch
from
18645ed to
5e3d974
Compare
neersighted
reviewed
Aug 11, 2023
api/types.proto
Outdated
| string seccomp_profile = 4; | ||
|
|
||
| // NoNewPrivileges, if set to true, disables the container from gaining new | ||
| // privileges. |
Member
There was a problem hiding this comment.
It might not hurt to link to It might not hurt to link to https://docs.kernel.org/userspace-api/no_new_privs.html here here.
This was referenced Aug 14, 2023
dperny
force-pushed
the
add-seccomp-apparmor
branch
2 times, most recently
from
60bd24a to
a68feeb
Compare
neersighted
suggested changes
Aug 21, 2023
api/types.proto
Outdated
| } | ||
| ApparmorMode mode = 1; | ||
| } | ||
| ApparmorOpts apparmor = 4; |
Member
There was a problem hiding this comment.
(All instances) probably should be AppArmor
| } | ||
| SELinuxContext selinux_context = 2 [(gogoproto.customname) = "SELinuxContext"]; | ||
|
|
||
| message SeccompOpts { |
Member
There was a problem hiding this comment.
Let's add a doc-comment describing the field, and maybe linking to the Docker seccomp docs
api/types.proto
Outdated
| } | ||
| SeccompOpts seccomp = 3; | ||
|
|
||
| message ApparmorOpts { |
Adds support for seccomp profiles, AppArmor profiles, and the no-new-privileges security options. This rounds out the present functionality of the --security-opt flag present for Docker containers. Signed-off-by: Drew Erny <[email protected]>
dperny
force-pushed
the
add-seccomp-apparmor
branch
from
a68feeb to
39ce17a
Compare
neersighted
approved these changes
Aug 22, 2023
Member
neersighted
left a comment
neersighted
left a comment
There was a problem hiding this comment.
LGTM, is this ready to come out of draft?
This was referenced Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for seccomp profiles, AppArmor profiles, and the no-new-privileges security options.
This rounds out the present functionality of the --security-opt flag present for Docker containers.