[WIP][18.09 backport] fix crash when there are attachments with null network #2825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
ping @andrewhsu @dperny @andrey-ko PTAL |
thaJeztah
force-pushed
the
18.09_backport_fix_crash
branch
from
104f1b0 to
eef2605
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## bump_v18.09 #2825 +/- ##
===============================================
+ Coverage 61.71% 61.85% +0.14%
===============================================
Files 134 134
Lines 21868 21870 +2
===============================================
+ Hits 13495 13528 +33
+ Misses 6919 6880 -39
- Partials 1454 1462 +8 |
thaJeztah
changed the title
Member
Author
|
marking this "WIP" as we should have the fix merged on master first |
Signed-off-by: Andrey Kolomentsev <[email protected]> (cherry picked from commit 5be0152) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
18.09_backport_fix_crash
branch
from
eef2605 to
6ae0a2f
Compare
Member
Author
|
rebased to get the latest version of the patch, but #2819 isn't merged yet, so keeping the "WIP" prefix |
Member
Author
|
closing, as 18.09 is EOL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #2819 for the 18.09 branch; cherry-pick was clean, no conflicts