Fix typo removable #2760
Closed
Fix typo removable #2760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rongzhang <[email protected]> Signed-off-by: Jean Rouge <[email protected]>
Contributor
Contributor
Author
|
@olljanat thanks, was actually doing this dummy PR to debug Circle, but hadn't had time to actually do it :) Reviewed your own PR, approved with one minor comment: #2756 (review) |
Contributor
Contributor
|
CI builds were failing because of containerd/protobuild#20 which broke protobuild for protoc 3.5.0. The fix is either containerd/protobuild#21 (not yet merged) or update to protoc 3.6.1 (#2756, merged, so CI is back to normal). Sorry for the mess 🐕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to repro the build failure from #2757