Skip to content

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Sep 7, 2019

(taken from #39846)

Modelled after the way it's handled in the Linux scripts

@thaJeztah
Copy link
Member Author

@StefanScherer @vikramhh ptal

@vikramhh
Copy link

vikramhh commented Sep 8, 2019

@thaJeztah - the change looks good to me. But why scope it to storage options alone?

By having the caller provide a fully crafted "additional" options as a string[say ADDITIONAL_DUT_OPTS] we could make the change more generic. The script will just tag that value on to $dutArgs without having to "parse" it in any way.

Caller would also be responsible for ensuring that nothing in ADDITIONAL_DUT_OPTS clashes with the options that the script uses anyways[e.g. --exec-opt].

@thaJeztah
Copy link
Member Author

I added this change for testing hyper-v containers; limiting just to storage driver options, so that we have the same variable name as elsewhere;

moby/Makefile

Line 52 in 9b25c0f

-e DOCKER_STORAGE_OPTS \

@cpuguy83 cpuguy83 merged commit 15d3310 into moby:master Sep 12, 2019
kolyshkin
kolyshkin approved these changes Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants