-
Notifications
You must be signed in to change notification settings - Fork 18.9k
integration-cli: remove redundant "testrequires" #39569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The `DockerDaemonSuite.SetUpTest` already checks for Linux and a local daemon;
```
func (s *DockerDaemonSuite) SetUpTest(c *check.C) {
testRequires(c, DaemonIsLinux, testEnv.IsLocalDaemon)
s.d = daemon.New(c, dockerBinary, dockerdBinary, testdaemon.WithEnvironment(testEnv.Execution))
}
```
Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
Looks like this one may be flaky: https://jenkins.dockerproject.org/job/Docker-PRs-experimental/46039/console |
|
Failing on WindowsRS1 https://jenkins.dockerproject.org/job/Docker-PRs-WoW-RS1/25971/console |
|
Wait! What's happening here? RS5 failed https://jenkins.dockerproject.org/job/Docker-PRs-WoW-RS5-Process/3055/console Then it continues with |
|
LGTM |
andrewhsu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cpuguy83
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The
DockerDaemonSuite.SetUpTestalready checks for Linux and a local daemon;