Skip to content

Conversation

@thaJeztah
Copy link
Member

The DockerDaemonSuite.SetUpTest already checks for Linux and a local daemon;

func (s *DockerDaemonSuite) SetUpTest(c *check.C) {
	testRequires(c, DaemonIsLinux, testEnv.IsLocalDaemon)
	s.d = daemon.New(c, dockerBinary, dockerdBinary, testdaemon.WithEnvironment(testEnv.Execution))
}

The `DockerDaemonSuite.SetUpTest` already checks for Linux and a local daemon;

```
func (s *DockerDaemonSuite) SetUpTest(c *check.C) {
	testRequires(c, DaemonIsLinux, testEnv.IsLocalDaemon)
	s.d = daemon.New(c, dockerBinary, dockerdBinary, testdaemon.WithEnvironment(testEnv.Execution))
}
```

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Member Author

Looks like this one may be flaky: https://jenkins.dockerproject.org/job/Docker-PRs-experimental/46039/console

09:09:19 --- FAIL: TestStopContainerWithTimeout (0.01s)
09:09:19     --- PASS: TestStopContainerWithTimeout/0 (1.17s)
09:09:19     --- PASS: TestStopContainerWithTimeout/3 (3.42s)
09:09:19     --- PASS: TestStopContainerWithTimeout/-1 (2.48s)
09:09:19     --- FAIL: TestStopContainerWithTimeout/1 (2.64s)
09:09:19         stop_linux_test.go:68: assertion failed: 42 (inspect.State.ExitCode int) != 137 (d.expectedExitCode int)

@thaJeztah
Copy link
Member Author

Failing on WindowsRS1 https://jenkins.dockerproject.org/job/Docker-PRs-WoW-RS1/25971/console

09:14:23 --- FAIL: TestRingLogger (0.10s)
09:14:23     ring_test.go:41: timeout reading log message
09:14:23 FAIL

@thaJeztah
Copy link
Member Author

Wait! What's happening here? RS5 failed https://jenkins.dockerproject.org/job/Docker-PRs-WoW-RS5-Process/3055/console

09:13:44 Running C:\gopath\src\github.com\docker\docker\integration\container
09:13:45 INFO: Windows Base image is  microsoft/windowsservercore
09:13:45 INFO: Testing against a local daemon

...

09:13:52 === RUN   TestHealthKillContainer
09:13:59 --- FAIL: TestHealthKillContainer (7.58s)
09:13:59     health_test.go:57: assertion failed: error is not nil: Error response from daemon: Invalid signal: SIGUSR1
...

09:16:21 --- SKIP: TestWaitBlocked (0.00s)
09:16:21     wait_test.go:59: testEnv.DaemonInfo.OSType != "linux"
09:16:21 FAIL
09:16:21 Running C:\gopath\src\github.com\docker\docker\integration\image

Then it continues with test-integration-cli

10:22:01 OK: 524 passed, 548 skipped
10:22:01 PASS
10:22:01 ok  	github.com/docker/docker/integration-cli	3921.066s
10:22:02 INFO: Integration tests ended at 07/19/2019 10:22:02. Duration:01:05:31.5617086

@crosbymichael
Copy link
Contributor

LGTM

Copy link
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants