[wip] Bump vishvananda/netlink to 1.0.0 #2118

thaJeztah · 2018-03-19T14:02:07Z

Full diff: vishvananda/netlink@b2de5d1...v1.0.0

Changes included:

Allow index specification at link creation time vishvananda/netlink#283 Allow index specification at link creation time
replace syscall with golang.org/x/sys/unix vishvananda/netlink#286 replace syscall with golang.org/x/sys/unix
- related: Use IFF_MULTI_QUEUE from x/sys/unix to define TUNTAP_MULTI_QUEUE vishvananda/netlink#330 Use IFF_MULTI_QUEUE from x/sys/unix to define TUNTAP_MULTI_QUEUE
- related: Use IFLA_* constants from x/sys/unix vishvananda/netlink#332 Use IFLA_* constants from x/sys/unix
Fix index out of range when no metadata for gretap vishvananda/netlink#287 Fix index out of range when no metadata for gretap
added encapsulation attributes for Iptun and Sittun to support SIT tunnels vishvananda/netlink#281 added encapsulation attributes for Iptun and Sittun to support SIT tunnels
Expose xfrm state's statistics vishvananda/netlink#288 Expose xfrm state's statistics
Support invert in ip rules vishvananda/netlink#290 Support invert in ip rules
Support LWTUNNEL_ENCAP_SEG6 vishvananda/netlink#282 Support LWTUNNEL_ENCAP_SEG6
vishvananda/netlink@63ca7e4 Support setting and retrieving route MTU/AdvMSS
Fix CalcRtable array parameter bug vishvananda/netlink#259 Fix CalcRtable array parameter bug
added support for Foo-over-UDP netlink calls vishvananda/netlink#285 added support for Foo-over-UDP netlink calls
Support num{tx,rx}queues and udp6zerocsum{tx,rx} vishvananda/netlink#225 Support num{tx,rx}queues and udp6zerocsum{tx,rx}
tuntap: Add multiqueue support vishvananda/netlink#293 tuntap: Add multiqueue support
Retrieve VLAN ID when listing neighbour vishvananda/netlink#227 Retrieve VLAN ID when listing neighbour
Fix LinkAdd for sit tunnel on 3.10 kernel vishvananda/netlink#301 Fix LinkAdd for sit tunnel on 3.10 kernel
Add support for managing source MACVLANs vishvananda/netlink#303 Add support for managing source MACVLANs
Two functions: one for adding bond slave, one for getting veth peer index vishvananda/netlink#307 Two functions: one for adding bond slave, one for getting veth peer index
Eliminate cgo from netlink. vishvananda/netlink#308 Eliminate cgo from netlink
Don't overwrite the XDP file descriptor with flags vishvananda/netlink#309 Don't overwrite the XDP file descriptor with flags
Fix reference to BPF instructions vishvananda/netlink#313 Fix reference to BPF instructions (on Kernel 4.13)
Add Matchall filter vishvananda/netlink#311 Add Matchall filter
Send IFA_CACHEINFO when setting up addresses vishvananda/netlink#315 Send IFA_CACHEINFO when setting up addresses
Support IPv6 GRE Tun and Tap vishvananda/netlink#317 Support IPv6 GRE Tun and Tap
Add List option to RouteSubscribeWithOptions, AddrSubscribeWithOptions, and LinkSubscribeWithOptions. vishvananda/netlink#318 Add List option to RouteSubscribeWithOptions, AddrSubscribeWithOptions, and LinkSubscribeWithOptions
Add Fq and Fq_Codel Qdisc support vishvananda/netlink#321 Add Fq and Fq_Codel Qdisc support

Looks like with this changes, only the system/meminfo code is needing CGO https://github.com/docker/libnetwork/blob/873af3416744d02ea044cf02a46d6dc3857b9062/vendor/github.com/docker/docker/pkg/system/meminfo_solaris.go#L1, which could probably be updated

thaJeztah · 2018-03-19T14:32:49Z

Looks like I need to update golang/x/sys/ accordingly;

# github.com/docker/libnetwork/vendor/github.com/vishvananda/netlink
vendor/github.com/vishvananda/netlink/bridge_linux.go:22:27: undefined: unix.IFLA_EXT_MASK
vendor/github.com/vishvananda/netlink/bridge_linux.go:38:9: undefined: unix.IFLA_AF_SPEC
vendor/github.com/vishvananda/netlink/bridge_linux.go:90:21: undefined: unix.IFLA_AF_SPEC
vendor/github.com/vishvananda/netlink/link_linux.go:380:23: undefined: unix.IFLA_VFINFO_LIST
vendor/github.com/vishvananda/netlink/link_linux.go:410:23: undefined: unix.IFLA_VFINFO_LIST
vendor/github.com/vishvananda/netlink/link_linux.go:440:23: undefined: unix.IFLA_VFINFO_LIST
vendor/github.com/vishvananda/netlink/link_linux.go:471:23: undefined: unix.IFLA_VFINFO_LIST
vendor/github.com/vishvananda/netlink/link_linux.go:505:23: undefined: unix.IFLA_VFINFO_LIST
vendor/github.com/vishvananda/netlink/link_linux.go:632:23: undefined: unix.IFLA_NET_NS_FD
vendor/github.com/vishvananda/netlink/link_linux.go:1004:28: undefined: unix.IFLA_NUM_TX_QUEUES
vendor/github.com/vishvananda/netlink/link_linux.go:1004:28: too many errors
# github.com/docker/libnetwork/ipvs
ipvs/ipvs.go:94:32: cannot use &tv (type *syscall.Timeval) as type *unix.Timeval in argument to sock.SetSendTimeout
ipvs/ipvs.go:98:35: cannot use &tv (type *syscall.Timeval) as type *unix.Timeval in argument to sock.SetReceiveTimeout
make: *** [build-local] Error 2
Makefile:27: recipe for target 'build-local' failed
make: *** [circle-ci-build] Error 2

Looks like this needs golang/sys@88d2dcc, so let me bump it to current master; also need to bump moby/moby, to pull in moby/moby@86f080c

Signed-off-by: Sebastiaan van Stijn <[email protected]>

Changes included: - Allow index specification at link creation time - replace syscall with golang.org/x/sys/unix - related: Use IFF_MULTI_QUEUE from x/sys/unix to define TUNTAP_MULTI_QUEUE - related: Use IFLA_* constants from x/sys/unix - Fix index out of range when no metadata for gretap - added encapsulation attributes for Iptun and Sittun to support SIT tunnels - Expose xfrm state's statistics - Support invert in ip rules - Support LWTUNNEL_ENCAP_SEG6 - Support setting and retrieving route MTU/AdvMSS - Fix CalcRtable array parameter bug - added support for Foo-over-UDP netlink calls - Support num{tx,rx}queues and udp6zerocsum{tx,rx} - tuntap: Add multiqueue support - Retrieve VLAN ID when listing neighbour - Fix LinkAdd for sit tunnel on 3.10 kernel - Add support for managing source MACVLANs - Two functions: one for adding bond slave, one for getting veth peer index - Eliminate cgo from netlink - Don't overwrite the XDP file descriptor with flags - Fix reference to BPF instructions (on Kernel 4.13) - Add Matchall filter - Send IFA_CACHEINFO when setting up addresses - Support IPv6 GRE Tun and Tap - Add List option to RouteSubscribeWithOptions, AddrSubscribeWithOptions, and LinkSubscribeWithOptions - Add Fq and Fq_Codel Qdisc support Signed-off-by: Sebastiaan van Stijn <[email protected]>

Signed-off-by: Sebastiaan van Stijn <[email protected]>

Also adds github.com/coreos/pkg as a dependency Signed-off-by: Sebastiaan van Stijn <[email protected]>

Signed-off-by: Sebastiaan van Stijn <[email protected]>

…faf27fd357b6 Signed-off-by: Sebastiaan van Stijn <[email protected]>

Signed-off-by: Sebastiaan van Stijn <[email protected]>

Also adds github.com/cyphar/filepath-securejoin Signed-off-by: Sebastiaan van Stijn <[email protected]>

Signed-off-by: Sebastiaan van Stijn <[email protected]>

thaJeztah · 2018-03-20T00:01:03Z

controller.go


 	if err != nil {
-		if err == plugins.ErrNotFound {
+		if errors.Cause(err) == plugins.ErrNotFound {


This fixes:

--- FAIL: TestUnknownDriver (15.00s) libnetwork_test.go:213: Did not fail with expected error. Actual error: could not find plugin unknowndriver in v1 plugin registry: plugin not found --- FAIL: TestNilRemoteDriver (15.00s) libnetwork_test.go:225: Did not fail with expected error. Actual error: could not find plugin framerelay in v1 plugin registry: plugin not found

Wonder if this is an actual issue currently; this was revealed due to docker/docker being bumped here, but likely is an issue in the current version in that repository

thaJeztah · 2018-03-20T00:01:38Z

controller.go


 	if err != nil {
-		if err == plugins.ErrNotFound {
+		if errors.Cause(err) == plugins.ErrNotFound {


Similar to the above, but not sure if there's a test case covering this;

--- FAIL: TestUnknownDriver (15.00s) libnetwork_test.go:213: Did not fail with expected error. Actual error: could not find plugin unknowndriver in v1 plugin registry: plugin not found --- FAIL: TestNilRemoteDriver (15.00s) libnetwork_test.go:225: Did not fail with expected error. Actual error: could not find plugin framerelay in v1 plugin registry: plugin not found

thaJeztah · 2018-03-20T00:02:40Z

Noticed this warning; will have to look into this one;

=== RUN   TestValidRemoteDriver
time="2018-03-19T18:21:21Z" level=warning msg="driver error deleting network dummy : NetworkDriver.DeleteNetwork: 404 page not found\n"

This looks like an actual failure:

=== RUN   TestRequestReleaseAddressDuplicate
--- FAIL: TestRequestReleaseAddressDuplicate (0.00s)
	allocator_test.go:1436: IP 198.168.0.226/23 was previously allocated

fcrisciani · 2018-03-27T16:23:53Z

cc @abhi looks like one of the IPAM tests failed here

amoghe · 2018-11-06T04:18:02Z

No <3 for this?

roffe · 2019-04-08T14:19:04Z

did this die in usersub?

euanh · 2019-06-24T12:40:21Z

Superseded by #2366

thaJeztah force-pushed the bump-netlink branch 6 times, most recently from 8f1e741 to d637c89 Compare March 19, 2018 18:16

thaJeztah changed the title ~~Bump vishvananda/netlink to 1.0.0~~ [wip] Bump vishvananda/netlink to 1.0.0 Mar 19, 2018

thaJeztah force-pushed the bump-netlink branch from d637c89 to 7292085 Compare March 19, 2018 22:59

thaJeztah added 14 commits March 20, 2018 00:38

bump golang.org/x/sys to 01acb38716e021ed1fc03a602bdb5838e1358c5e

34e73ac

Signed-off-by: Sebastiaan van Stijn <[email protected]>

bump docker/docker to 7270b01e5dd1fca3fd7fed0d6fb9d2769ec5f4ba

5aab2ce

Signed-off-by: Sebastiaan van Stijn <[email protected]>

Updates for golang/x/sys changes

311c9a8

Signed-off-by: Sebastiaan van Stijn <[email protected]>

Use "unix" instead of "syscall"

1e8ac21

Signed-off-by: Sebastiaan van Stijn <[email protected]>

Bump github.com/coreos/go-systemd to v15

d2f343a

Also adds github.com/coreos/pkg as a dependency Signed-off-by: Sebastiaan van Stijn <[email protected]>

Bump github.com/Microsoft/go-winio to 0.4.6

cf0bf30

Signed-off-by: Sebastiaan van Stijn <[email protected]>

Bump github.com/Microsoft/hcsshim to 0.6.8

04580f0

Signed-off-by: Sebastiaan van Stijn <[email protected]>

Bump github.com/docker/go-connections to 7beb39f0b969b075d1325fecb092…

925cf92

…faf27fd357b6 Signed-off-by: Sebastiaan van Stijn <[email protected]>

Bump image-spec and runtime-spec to 1.0.1

3ddb6d8

Signed-off-by: Sebastiaan van Stijn <[email protected]>

bump runc to 4fc53a81fb7c994640722ac585fa9ca548971871

99f50b9

Also adds github.com/cyphar/filepath-securejoin Signed-off-by: Sebastiaan van Stijn <[email protected]>

Bump opencontainers/selinux to b29023b86e4a69d1b46b7e7b4e2b6fda03f0b9cd

e0e898c

Signed-off-by: Sebastiaan van Stijn <[email protected]>

Bump containerd/console to 2748ece16665b45a47f884001d5831ec79703880

45af83c

Signed-off-by: Sebastiaan van Stijn <[email protected]>

Bump containerd/continuity to d8fb8589b0e8e85b8c8bbaa8840226d0dfeb7371

cc7c9d9

Signed-off-by: Sebastiaan van Stijn <[email protected]>

thaJeztah force-pushed the bump-netlink branch from 7292085 to cc7c9d9 Compare March 19, 2018 23:40

thaJeztah commented Mar 20, 2018

View reviewed changes

thaJeztah mentioned this pull request Oct 18, 2018

ipvs.go:94:32: cannot use &tv (type *syscall.Timeval) as type *unix.Timeval in argument to sock.SetSendTimeout #2110

Closed

This was referenced Apr 10, 2019

Fix TestValidRemoteDriver GetCapabilities errors #2364

Merged

controller.loadIPAMDriver: Unwrap error type returned by PluginGetter #2365

Merged

Bump vishvananda/netlink to 1.0.0 #2366

Merged

euanh closed this Jun 24, 2019

thaJeztah deleted the bump-netlink branch June 24, 2019 12:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[wip] Bump vishvananda/netlink to 1.0.0 #2118

[wip] Bump vishvananda/netlink to 1.0.0 #2118

Uh oh!

thaJeztah commented Mar 19, 2018 •

edited

Loading

Uh oh!

thaJeztah commented Mar 19, 2018 •

edited

Loading

Uh oh!

thaJeztah Mar 20, 2018

Uh oh!

thaJeztah Mar 20, 2018

Uh oh!

thaJeztah Mar 20, 2018

Uh oh!

thaJeztah commented Mar 20, 2018

Uh oh!

fcrisciani commented Mar 27, 2018

Uh oh!

amoghe commented Nov 6, 2018

Uh oh!

roffe commented Apr 8, 2019

Uh oh!

euanh commented Jun 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[wip] Bump vishvananda/netlink to 1.0.0 #2118

[wip] Bump vishvananda/netlink to 1.0.0 #2118

Uh oh!

Conversation

thaJeztah commented Mar 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thaJeztah commented Mar 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thaJeztah Mar 20, 2018

Choose a reason for hiding this comment

Uh oh!

thaJeztah Mar 20, 2018

Choose a reason for hiding this comment

Uh oh!

thaJeztah Mar 20, 2018

Choose a reason for hiding this comment

Uh oh!

thaJeztah commented Mar 20, 2018

Uh oh!

fcrisciani commented Mar 27, 2018

Uh oh!

amoghe commented Nov 6, 2018

Uh oh!

roffe commented Apr 8, 2019

Uh oh!

euanh commented Jun 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

thaJeztah commented Mar 19, 2018 •

edited

Loading

thaJeztah commented Mar 19, 2018 •

edited

Loading