test: avoid the error message when creating a user #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
SGTM |
AkihiroSuda
reviewed
Mar 21, 2019
hack/dockerfiles/test.Dockerfile
Outdated
| FROM buildkit-base AS integration-tests | ||
| ENV BUILDKIT_INTEGRATION_ROOTLESS_IDPAIR="1000:1000" | ||
| RUN apk add --no-cache shadow shadow-uidmap sudo \ | ||
| && [ -d /var/mail ] || mkdir /var/mail \ |
Collaborator
Author
There was a problem hiding this comment.
Both are okay I think, "/var" is there, no need "-p" option here.
Member
There was a problem hiding this comment.
-p allows skipping [ -d /var/mail ] check
Member
There was a problem hiding this comment.
Other approach can be found here; docker/cli#1728
/cc @ijc
Run this command: `docker build --tag davetest -f ./hack/dockerfiles/test.Dockerfile --target integration-tests` Will throw this error message: `Executing busybox-1.29.3-r10.trigger OK: 184 MiB in 43 packages Creating mailbox file: No such file or directory` Not impact functionality but a little bit annoying. Signed-off-by: Dave Chen <[email protected]>
AkihiroSuda
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run this command:
docker build -f ./hack/dockerfiles/test.Dockerfile --target integration-testswill throw this error message:
`Executing busybox-1.29.3-r10.trigger OK: 184 MiB in 43 packages
Creating mailbox file: No such file or directory`
Not impact functionality but a little bit annoying.
Signed-off-by: Dave Chen [email protected]