solver: add ResolverCache support #6293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
force-pushed
the
add-resolvercache
branch
4 times, most recently
from
7704ed9 to
c2622a1
Compare
|
Added an additional commit for the Git case when reference changes to a different commit in the middle of the build request. |
This was referenced Oct 16, 2025
crazy-max
approved these changes
Oct 17, 2025
New ResolverCache interface in JobContext allows build jobs to memorize and synchronize accesses to mutable remote resources. This is to make sure that when multiple parts of the same build job, or build job and source metadata resolver access the same remote resources, it remains the same for the duration of the single build request, even if data happens to change on the remote side. Fix such a possible case in the HTTP source. Even if the server now returns completely different data, if the same URL was accessed once for the ongoing build, then the initial contents are always used until the build completes. Signed-off-by: Tonis Tiigi <[email protected]>
Make sure remote ref does not change to different commit if git repo changes in the middle of the build. Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
add-resolvercache
branch
from
c2622a1 to
1cff633
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New ResolverCache interface in JobContext allows build jobs to memorize and synchronize accesses to mutable remote resources.
This is to make sure that when multiple parts of the same build job, or build job and source metadata resolver access the same remote resources, it remains the same for the duration of the single build request, even if data happens to change on the remote side.
Fix such a possible case in the HTTP source. Even if the server now returns completely different data, if the same URL was accessed once for the ongoing build, then the initial contents are always used until the build completes.
LLM disclaimer: Unit tests for resolverCache and combinedResolverCache were initially GPT-5 generated