chore: upgrade golang.org/x/exp to 20250911091902 #6260
Conversation
Fixes the in-flight trace recorder getting stuck when exporting a trace when buildkit is compiled with go 1.24. Signed-off-by: Alberto Garcia Hierro <[email protected]>
github-actions
bot
added
the
area/dependencies
|
|
||
| // This file implements conversion from old (Go 1.11–Go 1.21) traces to the Go | ||
| // 1.22 format. | ||
| // This file implements conversion from v1 (Go 1.11–Go 1.21) traces to the v2 |
There was a problem hiding this comment.
This is something I noticed last week; there's a v2 now, and v1 is implemented using v2; I wondered; should we be switching to v2?
But I'm not familiar at all with how it's used, so wanted to ask you 😅
There was a problem hiding this comment.
v1 implements support for Go runtime traces up until Go 1.21. For Go 1.22 they redid the internals of runtime tracing and started using a new format to store them, which is supported by the v2 package.
AFAIK, v1 and v2 packages are internal. The public API continues to be the same, and the format of the trace is determined by the Go version used to build the program.
What changed recently is that they renamed the internal packages (v1 as called oldtrace, v2 was called go122).
There was a problem hiding this comment.
Oh! You are SO right! I completely missed the .. rather relevant .. internal/ in the path!
I recall I was about to vendor an update, then noticed the v1 / v2, and knowing that golang.org/x/exp is known for being experimental and breaking changes can happen, made a mental note "check if we should update our uses, because for this module we should keep up with changes made".
But nothing to do then, thanks!!
4 participants
Fixes the in-flight trace recorder getting stuck when exporting a trace
when buildkit is compiled with go 1.24.