Skip to content

update binfmt to v10.0.4 #6215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

update binfmt to v10.0.4 #6215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,10 @@ FROM scratch AS cni-plugins-export-squashed
COPY --from=cni-plugins-export / /

FROM --platform=$BUILDPLATFORM alpine:${ALPINE_VERSION} AS binfmt-filter
# built from https://github.com/tonistiigi/binfmt/releases/tag/buildkit%2Fv9.2.2-54
COPY --link --from=tonistiigi/binfmt:buildkit-v9.2.2-54@sha256:e60fbf01e26c75efa816224f4de31c2ef63c5486b20c3e8fa1e5da2aff368ba9 / /out/
# built from https://github.com/tonistiigi/binfmt/releases/tag/buildkit%2Fv10.0.4-57
COPY --link --from=tonistiigi/binfmt:buildkit-v10.0.4-57@sha256:370775754cd56094fff210b44968bf15777aed7eb3302df4f7ab2b647630899e / /out/
WORKDIR /out/
RUN rm buildkit-qemu-loongarch64 buildkit-qemu-mips64 buildkit-qemu-mips64el
RUN rm -f buildkit-qemu-loongarch64 buildkit-qemu-mips64 buildkit-qemu-mips64el
Copy link
Member

@tonistiigi tonistiigi Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the -f?

Copy link
Member Author

@crazy-max crazy-max Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because since v10 it would fail for arm because it doesn't build 64-bits anymore: https://github.com/moby/buildkit/actions/runs/17645081615/job/50140976792#step:7:309

  > [linux/amd64 binfmt-filter 4/4] RUN rm buildkit-qemu-loongarch64 buildkit-qemu-mips64 buildkit-qemu-mips64el:
0.084 rm: can't remove 'buildkit-qemu-loongarch64': No such file or directory
0.084 rm: can't remove 'buildkit-qemu-mips64': No such file or directory
0.084 rm: can't remove 'buildkit-qemu-mips64el': No such file or directory

Copy link
Member Author

@crazy-max crazy-max Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relates to https://github.com/tonistiigi/binfmt/pull/265/files#diff-e01d1ed40012518673813c6071f1de321ec959c7204a2264efb33c1ec5366f79R11-R19


FROM scratch AS binaries-linux
COPY --link --from=runc /usr/bin/runc /buildkit-runc
Expand Down