-
Notifications
You must be signed in to change notification settings - Fork 1.3k
contrib: check nvidia drivers and support non PCI-based GPUs for WSL #5880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
reviewed
Mar 26, 2025
Signed-off-by: CrazyMax <[email protected]>
36ed40a to
da31bd4
Compare
da31bd4 to
e2ef5e5
Compare
tonistiigi
reviewed
Mar 28, 2025
Signed-off-by: CrazyMax <[email protected]>
e2ef5e5 to
f85a66c
Compare
tonistiigi
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't support non PCI-based nvidia GPUs like it is on WSL:
There is no
vendorordevicewhich typically appear for PCI-based GPUs. Since the device looks underbus/platforminstead ofbus/pci, it is likely a WSL-specific GPU mapping that doesn't expose PCI info.WSL2 maps GPUs through DirectX, and the presence of
/dev/dxgmeans a GPU is available but we don't know what vendor (could be Intel, Nvidia, AMD, ...).So as best-effort we can assume that non PCI-based nvidia GPUs for WSL don't need drivers installation and can directly generate the CDI specification.
We also need to check if drivers are installed for both Linux and WSL. We are relying on libcuda install location for this. This is specially useful since buildx request gpu when creating the container builder related: docker/buildx#3063
Generated CDI specs within the container builder: