ci: Fix govulncheck permissions #5326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… able to checkout the repository. Signed-off-by: Silvin Lubecki <[email protected]>
crazy-max
approved these changes
Sep 12, 2024
Member
|
Curious though; looking at merged PRs on master, it doesn't complain when checking out the code, or was it failing in other ways? https://github.com/moby/buildkit/actions/runs/10821255341/job/30022906774#step:2:253 |
Contributor
Author
That is because the repository is available publicly 😸 |
Member
|
Oh!!! Gotcha. That's a good one; I know we also have private security forks of moby/moby and docker/cli to test security patches before release. I guess I should check if those should also be updated. |
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It needs at least content read to be able to checkout the repository.