Skip to content

Get build info from mmtk-core#174

Merged
qinsoon merged 6 commits intommtk:masterfrom
qinsoon:tph-version
Aug 15, 2022
Merged

Get build info from mmtk-core#174
qinsoon merged 6 commits intommtk:masterfrom
qinsoon:tph-version

Conversation

@qinsoon
Copy link
Copy Markdown
Member

@qinsoon qinsoon commented Aug 10, 2022

This PR implements ThirdPartyHeap::version() for mmtk/openjdk#14.

@qinsoon qinsoon marked this pull request as ready for review August 11, 2022 00:56
@qinsoon qinsoon requested a review from wks August 11, 2022 00:56
Copy link
Copy Markdown
Contributor

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon merged commit 688791e into mmtk:master Aug 15, 2022
@k-sareen
Copy link
Copy Markdown
Collaborator

k-sareen commented Aug 17, 2022

I know the PR has merged already, but can I suggest adding the enabled features to the version string (or somewhere in --version) as well? For example, what I do when I copy builds is I name the build as jdk11-core_<mmtk-core git-hash>-jdk_<mmtk-openjdk git-hash>-vm_<openjdk git-hash>-<feature1>-<feature2>. It would make the builds more reproducible.

Nevermind. That's part of the mmtk-core PR. Missed it, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants