Abort for GC thread panic #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udesou
approved these changes
Jan 23, 2025
Contributor
udesou
left a comment
udesou
left a comment
There was a problem hiding this comment.
LGTM. I can open a PR to backport it to master or did you set up a bot to do so?
Member
Author
It will be great if you can port this to master. I only set up ergify to backport from |
qinsoon
added a commit
that referenced
this pull request
Jan 23, 2025
Porting #221 to `master`. Co-authored-by: Yi Lin <[email protected]>
qinsoon
added a commit
to qinsoon/mmtk-julia
that referenced
this pull request
Feb 6, 2025
The code is mainly from `mmrk-ruby`. We hijack the Rust panic hook to make sure that if the GC threads panic, the process will be aborted. The current behavior is that when a GC thread panics, the process hangs and wait for that GC thread to finish its work. This should be ported to `master`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is mainly from
mmrk-ruby. We hijack the Rust panic hook to make sure that if the GC threads panic, the process will be aborted. The current behavior is that when a GC thread panics, the process hangs and wait for that GC thread to finish its work.This should be ported to
master.