Skip to content

Fix julia extended tests #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qinsoon merged 4 commits into from
Feb 6, 2025
Merged

Fix julia extended tests #1270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d01a9b7
Check out upstream/master
qinsoon Feb 5, 2025
52cb51b
Only run Julia tests
qinsoon Feb 5, 2025
ad2d7ee
Allow us to specify which Julia version to run with. The default for …
qinsoon Feb 5, 2025
94d2784
Revert "Only run Julia tests"
qinsoon Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/extended-tests-bindings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ jobs:
- name: Setup
run: |
cd mmtk-julia
./.github/scripts/ci-checkout.sh
./.github/scripts/ci-checkout.sh ${{ needs.binding-refs.outputs.julia_vm_repo }} ${{ needs.binding-refs.outputs.julia_vm_ref }}
./.github/scripts/ci-setup.sh
sed -i 's/^mmtk[[:space:]]=/#ci:mmtk=/g' mmtk/Cargo.toml
sed -i 's/^#[[:space:]]mmtk/mmtk/g' mmtk/Cargo.toml
Expand Down
29 changes: 27 additions & 2 deletions .github/workflows/pr-binding-refs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
# V8_BINDING_REF=xxxxxx
# JULIA_BINDING_REPO=xx/xx
# JULIA_BINDING_REF=xxxxxx
# JULIA_VM_REPO=xx/xx
# JULIA_VM_REF=xxxxxx
# RUBY_BINDING_REPO=xx/xx
# RUBY_BINDING_REF=xxxxxx
# ```
Expand Down Expand Up @@ -86,6 +88,21 @@ on:
julia_binding_ref_default:
description: "The default git ref of Julia binding, such as sha and branch name"
value: ${{ jobs.binding-refs.outputs.julia_binding_ref_default }}
# We further define the Julia version to run with, as we no longer record the Julia
# version with each binding commit. Instead, we record the binding version with
# each Julia commit.
julia_vm_repo:
description: "The repository of Julia, such as {user}/{repo}"
value: ${{ jobs.binding-refs.outputs.julia_vm_repo }}
julia_vm_repo_default:
description: "The default repository of Julia, such as {user}/{repo}"
value: ${{ jobs.binding-refs.outputs.julia_vm_repo_default }}
julia_vm_ref:
description: "The git ref of Julia, such as sha and branch name"
value: ${{ jobs.binding-refs.outputs.julia_vm_ref }}
julia_vm_ref_default:
description: "The default git ref of Julia, such as sha and branch name"
value: ${{ jobs.binding-refs.outputs.julia_vm_ref_default }}

ruby_binding_repo:
description: "The repository of Ruby binding, such as {user}/{repo}"
Expand All @@ -111,7 +128,9 @@ jobs:
V8_BINDING_REPO_DEFAULT: mmtk/mmtk-v8
V8_BINDING_REF_DEFAULT: master
JULIA_BINDING_REPO_DEFAULT: mmtk/mmtk-julia
JULIA_BINDING_REF_DEFAULT: dev
JULIA_BINDING_REF_DEFAULT: master
JULIA_VM_REPO_DEFAULT: JuliaLang/julia
JULIA_VM_REF_DEFAULT: master
RUBY_BINDING_REPO_DEFAULT: mmtk/mmtk-ruby
RUBY_BINDING_REF_DEFAULT: master
outputs:
Expand All @@ -131,6 +150,10 @@ jobs:
julia_binding_repo_default: ${{ env.JULIA_BINDING_REPO_DEFAULT }}
julia_binding_ref: ${{ steps.print.outputs.julia_binding_ref }}
julia_binding_ref_default: ${{ env.JULIA_BINDING_REF_DEFAULT }}
julia_vm_repo: ${{ steps.print.outputs.julia_vm_repo }}
julia_vm_repo_default: ${{ env.JULIA_VM_REPO_DEFAULT }}
julia_vm_ref: ${{ steps.print.outputs.julia_vm_ref }}
julia_vm_ref_default: ${{ env.JULIA_VM_REF_DEFAULT }}
ruby_binding_repo: ${{ steps.print.outputs.ruby_binding_repo }}
ruby_binding_repo_default: ${{ env.RUBY_BINDING_REPO_DEFAULT }}
ruby_binding_ref: ${{ steps.print.outputs.ruby_binding_ref }}
Expand All @@ -141,7 +164,7 @@ jobs:
with:
pull_request: ${{ inputs.pull_request }}
token: ${{ secrets.GITHUB_TOKEN }}
default_env: 'OPENJDK_BINDING_REPO=${{ env.OPENJDK_BINDING_REPO_DEFAULT }},OPENJDK_BINDING_REF=${{ env.OPENJDK_BINDING_REF_DEFAULT }},JIKESRVM_BINDING_REPO=${{ env.JIKESRVM_BINDING_REPO_DEFAULT }},JIKESRVM_BINDING_REF=${{ env.JIKESRVM_BINDING_REF_DEFAULT }},V8_BINDING_REPO=${{ env.V8_BINDING_REPO_DEFAULT }},V8_BINDING_REF=${{ env.V8_BINDING_REF_DEFAULT }},JULIA_BINDING_REPO=${{ env.JULIA_BINDING_REPO_DEFAULT }},JULIA_BINDING_REF=${{ env.JULIA_BINDING_REF_DEFAULT }},RUBY_BINDING_REPO=${{ env.RUBY_BINDING_REPO_DEFAULT }},RUBY_BINDING_REF=${{ env.RUBY_BINDING_REF_DEFAULT }}'
default_env: 'OPENJDK_BINDING_REPO=${{ env.OPENJDK_BINDING_REPO_DEFAULT }},OPENJDK_BINDING_REF=${{ env.OPENJDK_BINDING_REF_DEFAULT }},JIKESRVM_BINDING_REPO=${{ env.JIKESRVM_BINDING_REPO_DEFAULT }},JIKESRVM_BINDING_REF=${{ env.JIKESRVM_BINDING_REF_DEFAULT }},V8_BINDING_REPO=${{ env.V8_BINDING_REPO_DEFAULT }},V8_BINDING_REF=${{ env.V8_BINDING_REF_DEFAULT }},JULIA_BINDING_REPO=${{ env.JULIA_BINDING_REPO_DEFAULT }},JULIA_BINDING_REF=${{ env.JULIA_BINDING_REF_DEFAULT }},JULIA_VM_REPO=${{ env.JULIA_VM_REPO_DEFAULT }},JULIA_VM_REF=${{ env.JULIA_VM_REF_DEFAULT }},RUBY_BINDING_REPO=${{ env.RUBY_BINDING_REPO_DEFAULT }},RUBY_BINDING_REF=${{ env.RUBY_BINDING_REF_DEFAULT }}'
- id: print
run: |
echo "openjdk_binding_repo=${{ env.OPENJDK_BINDING_REPO }}" >> $GITHUB_OUTPUT
Expand All @@ -152,5 +175,7 @@ jobs:
echo "v8_binding_ref=${{ env.V8_BINDING_REF }}" >> $GITHUB_OUTPUT
echo "julia_binding_repo=${{ env.JULIA_BINDING_REPO }}" >> $GITHUB_OUTPUT
echo "julia_binding_ref=${{ env.JULIA_BINDING_REF }}" >> $GITHUB_OUTPUT
echo "julia_vm_repo=${{ env.JULIA_VM_REPO }}" >> $GITHUB_OUTPUT
echo "julia_vm_ref=${{ env.JULIA_VM_REF }}" >> $GITHUB_OUTPUT
echo "ruby_binding_repo=${{ env.RUBY_BINDING_REPO }}" >> $GITHUB_OUTPUT
echo "ruby_binding_ref=${{ env.RUBY_BINDING_REF }}" >> $GITHUB_OUTPUT