Skip to content

Clear stale line mark state #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qinsoon merged 2 commits into from
Jan 29, 2025
Merged

Clear stale line mark state #1268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7f65f3
clear stale line mark state
tianleq Jan 28, 2025
41c0c3c
minor fix
tianleq Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/policy/immix/block.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,11 @@ impl Block {
if prev_line_is_marked {
holes += 1;
}

// We need to clear the line mark state at least twice in every 128 GC
// otherwise, the line mark state of the last GC will stick around
if line_mark_state > Line::MAX_MARK_STATE - 2 {
line.mark(0);
}
#[cfg(feature = "immix_zero_on_release")]
crate::util::memory::zero(line.start(), Line::BYTES);

Expand Down
3 changes: 3 additions & 0 deletions src/util/alloc/immix_allocator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,9 @@ impl<VM: VMBinding> ImmixAllocator<VM> {
block.start(),
block.end()
);
// Bulk clear stale line mark state
Line::MARK_TABLE
.bzero_metadata(block.start(), crate::policy::immix::block::Block::BYTES);
if self.request_for_large {
self.large_bump_pointer.cursor = block.start();
self.large_bump_pointer.limit = block.end();
Expand Down