Conversation
Necessary to allow the project to compile using GCC as well as Clang.
The sign comparison warning will need to be fixed later. There are also some raytracing failures which need to be resolved before we merge this to main.
Remove refactoring comments which weren't meant to be kept earlier and were introducing test failures.
Move logic from header files into new .cpp implementation files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove C++20 modules from the project, since they were causing compilation issues for gcc and msvc. It is also good to have a typical hpp/cpp version of the project to point people to, so this will likely remain a branch if we choose to reintroduce modules in the future.