Links to menu items are written as absolute links

[olbat]

Description

The #1588 PR was supposed to:

Replace absolute_url filter with relative_url where it makes sense (asset/navigation related paths).

Is there any reasons to keep links to menu items as absolute links ?

Environment

• Minimal Mistakes version: 4.12.1

Expected behavior

Links to menu items to be written as relative links as well ?
(works better with "reverse-proxified" websites)

[mmistakes]

It could absolutely be updated.

I use something like the following in my other theme's which cuts down on some of the Liquid spaghetti code currently in MM.

{%- for link in site.data.navigation.main -%}
  {%- if link.url contains '://' -%}
    {%- assign url = link.url -%}
  {%- else -%}
    {%- assign url = link.url | relative_url -%}
  {%- endif -%}
  <li><!-- anchor stuff --></li>
{%- endfor -%}

Happy to look at a pull request if anyone wants to take a stab at cleaning up_includes/masthead.html.

[olbat]

Nice! Thank you for your code snippet 👍
I've opened a PR using it, please let me know if there is anything wrong ...

[ptsiampas]

I was a little more brutal than that by removing the {{domain}} from line 14, it was driving me mental for hours. :)
Glad you have fixed it with the snippet.