Skip to content

Allowing user to set flutter version #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atrope wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allowing user to set flutter version #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cac72b2
Allowing user to set flutter version
atrope May 25, 2020
78f3fd8
update version from test_spec
atrope May 25, 2020
7f33aec
rollback version
atrope May 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/resources/test_spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ phases:

# install flutter
- echo "Install flutter"
- FLUTTER_VERSION='v1.12.13+hotfix.8-stable'
- echo "FLUTTER_VERSION=$FLUTTER_VERSION"
- >-
if [ $DEVICEFARM_DEVICE_PLATFORM_NAME = "Android" ];
then
Expand Down
7 changes: 6 additions & 1 deletion lib/src/resources.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,14 @@ import 'package:tool_base/tool_base.dart';
const kResourcesUri = 'package:sylph/resources';
const kAppiumTemplateZip = 'appium_bundle.zip';
const kAppiumTestSpecName = 'test_spec.yaml';
const kdefaultFlutterVersion = '1.17.1-stable';
const kTestBundleDir = 'test_bundle';
const kTestBundleZip = '$kTestBundleDir.zip';
const kBuildToOsMapFileName = 'build_to_os.txt';

// env vars
const kCIEnvVar = 'CI'; // detects if running in CI
const kFlutterVersionEnvVar = 'FLUTTER_VERSION';
const kExportOptionsPlistEnvVars = [
// required for iOS build locally and in CI
'TEAM_ID'
Expand Down Expand Up @@ -43,7 +45,10 @@ Future<void> unpackResources(String tmpDir, bool isIosPoolTypeActive,
'$tmpDir/$kAppiumTemplateZip');

// unpack Appium test spec
await unpackFile(kAppiumTestSpecName, tmpDir);
await unpackFile(kAppiumTestSpecName, tmpDir, nameVals: {
kFlutterVersionEnvVar:
platform.environment[kFlutterVersionEnvVar] ?? kdefaultFlutterVersion
});

// unpack scripts
await unpackScripts(tmpDir);
Expand Down