Add CLI entrypoint test and mark slow tests #23#95
Open
AdityaGupta716 wants to merge 2 commits intomllam:mainfrom
Open
Add CLI entrypoint test and mark slow tests #23#95AdityaGupta716 wants to merge 2 commits intomllam:mainfrom
AdityaGupta716 wants to merge 2 commits intomllam:mainfrom
Conversation
Author
|
hi @leifdenby plz review — let me know if the approach works for you! |
Member
|
Please revert to using the default PR template here. Once you've done that you can tag me for a review :) thank you! |
d4bc422 to
c9c4dd2
Compare
Author
|
@leifdenby Plz review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added a test for the actual installed CLI entry point by running it as a subprocess with
--help. This catches import/dependency errors (like a missingpsutildependency) that would not be caught by calling the Python function directly.Marked the existing
test_callas@pytest.mark.slowsince it requires network access and AWS credentials to run. Registered theslowmark inpyproject.tomlto avoid pytest warnings about unknown marks.Issue Link
Closes #23
Type of change
Checklist before requesting a review
Author checklist after completed review