Skip to content

Bugfix for input order effecting coord ranges slicing in output#90

Merged
leifdenby merged 9 commits intomllam:mainfrom
leifdenby:bugfix/coord_ranges-slicing-order
Feb 10, 2026
Merged

Bugfix for input order effecting coord ranges slicing in output#90
leifdenby merged 9 commits intomllam:mainfrom
leifdenby:bugfix/coord_ranges-slicing-order

Conversation

@leifdenby
Copy link
Member

@leifdenby leifdenby commented Feb 9, 2026

Describe your changes

As reported on #81 there is currently a bug in mllam-data-prep where the order of the inputs affects how the coord_ranges selection on the output is applied. This is because the variable holding the coordinate ranges to slice over was being mutated when looping over the output variables.

This was also worked on by @zweihuehner in #87, but something went wrong in the most recent commit there :) I also add a test in this PR to expose the bug to ensure it has been fully fixed.

No change in dependencies needed for this fix

Issue Link

solves #81

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 Documentation (Addition or improvements to documentation)

Checklist before requesting a review

  • My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
  • I have performed a self-review of my code
  • For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
  • I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
  • I have updated the documentation to cover introduced code changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have given the PR a name that clearly describes the change, written in imperative form (context).
  • I have requested a reviewer and an assignee (assignee is responsible for merging)

Checklist for reviewers

Each PR comes with its own improvements and flaws. The reviewer should check the following:

  • the code is readable
  • the code is well tested
  • the code is documented (including return types and parameters)
  • the code is easy to maintain

Author checklist after completed review

  • I have added a line to the CHANGELOG describing this change, in a section
    reflecting type of change (add section where missing):
    • added: when you have added new functionality
    • changed: when default behaviour of the code has been changed
    • fixes: when your contribution fixes a bug

Checklist for assignee

  • PR is up to date with the base branch
  • the tests pass
  • author has added an entry to the changelog (and designated the change as added, changed or fixed)
  • Once the PR is ready to be merged, squash commits and merge the PR.

@leifdenby
Copy link
Member Author

The added test fails now (https://github.com/mllam/mllam-data-prep/actions/runs/21825781800/job/62970260047?pr=90#step:5:28) as it should for all permutations of the inputs apart from those where static is last (the one for which selection over time isn't selected)

@leifdenby leifdenby changed the title Bugfix/coord ranges slicing order Bugfix for input order effecting coord ranges slicing in output Feb 9, 2026
@leifdenby leifdenby requested a review from zweihuehner February 9, 2026 13:15
Copy link
Contributor

@zweihuehner zweihuehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@leifdenby leifdenby merged commit cbcfe3a into mllam:main Feb 10, 2026
6 checks passed
@leifdenby
Copy link
Member Author

thanks for your help @zweihuehner !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants