Bugfix for input order effecting coord ranges slicing in output#90
Merged
leifdenby merged 9 commits intomllam:mainfrom Feb 10, 2026
Merged
Conversation
…in all of state/static/forcing mllam#81
Clarified comments regarding coordinate range selection and static features.
Member
Author
|
The added test fails now (https://github.com/mllam/mllam-data-prep/actions/runs/21825781800/job/62970260047?pr=90#step:5:28) as it should for all permutations of the inputs apart from those where |
…oord_ranges-slicing-order
Member
Author
|
thanks for your help @zweihuehner ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
As reported on #81 there is currently a bug in
mllam-data-prepwhere the order of the inputs affects how thecoord_rangesselection on the output is applied. This is because the variable holding the coordinate ranges to slice over was being mutated when looping over the output variables.This was also worked on by @zweihuehner in #87, but something went wrong in the most recent commit there :) I also add a test in this PR to expose the bug to ensure it has been fully fixed.
No change in dependencies needed for this fix
Issue Link
solves #81
Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee