Merged
Conversation
Contributor
Author
|
Looks like xarray>=2024.2.0 requires python 3.9 or later. Should we drop support for 3.8? @khintz @leifdenby |
I would be fine with dropping 3.8 |
Contributor
Author
|
Oh it looks like we already require python>=3.9, we probably just forgot to remove the test for 3.8. I've done that now. |
leifdenby
approved these changes
May 12, 2025
Member
leifdenby
left a comment
There was a problem hiding this comment.
Looks great! Thanks for doing this ⭐
This was referenced May 13, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Tests did not use the pinned python version from the test matrix, they all ran on newest available version (3.12).
Therefore, a bug caused by using the typing annotation with
|instead ofUniondid not raise an error, even though that is only compatible with python >=3.10.This PR fixes that bug, and lets the tests use the expected python version.
Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee