update min version of dataclass-wizard to v0.29.2#73
Merged
leifdenby merged 3 commits intomllam:mainfrom Mar 27, 2025
Merged
Conversation
…maint/update-dataclass-wizard-dep
There was a problem hiding this comment.
Pull Request Overview
This PR updates the minimum required version of the dataclass-wizard dependency to v0.29.2 to address a bug that affected Union type handling in configuration validation.
- Bumped dataclass-wizard dependency from 0.22.3 to 0.29.2.
- Ensures that config YAML files are correctly validated against dataclass definitions supporting union types.
khintz
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Update minimum version of
dataclass-wizardto0.29.2which fixed bug which meant it wasn't possible to defineUniontypes while checking that all keys in the loaded yaml-config file matched a field in the config dataclass (rnag/dataclass-wizard#137). The presence of this bug meant inneural-lamthat we had to keepraise_on_unknown_json_keyto its defaultFalsevalue. We should ensure that people have a version ofdataclass-wizardinstalled that means we can check the config yaml against the config dataclass while supporting union types.I have run the tests both against
0.29.2and also0.35.0(whichdataclass-wizard>=0.29.2currently resolves to) ofdataclass-wizard.Issue Link
Closes #43
Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee