use field default-factory for optional dict fields

[leifdenby]

Describe your changes

This PR fixes a bug with the config specification for fields that are of dict type but are optional. I had previously thought it was ok to set these to None by default, but that doesn't work because when constructing the nested dataclasses the initialisation tries to iterate over the .items() in these optional fields. Since these fields were defaulting to None this would raise an AttributeError. Instead for fields of dict type where these fields are optional one must use a dataclass.field(default_factory={}) constructor so that an empty dict is created when intialising the dataclass object.

I think @mafdmi noticed this earlier and has already fixed some of these issues, but I spotted a few more just now when working on the config serialisation feature #46.

No dependencies change

Issue Link

No related issue

Type of change

• 🐛 Bug fix (non-breaking change that fixes an issue)
• ✨ New feature (non-breaking change that adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 📖 Documentation (Addition or improvements to documentation)

Checklist before requesting a review

• My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
• I have performed a self-review of my code
• For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
• I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
• I have updated the documentation to cover introduced code changes
• I have added tests that prove my fix is effective or that my feature works
• I have given the PR a name that clearly describes the change, written in imperative form (context).
• I have requested a reviewer and an assignee (assignee is responsible for merging)

Checklist for reviewers

Each PR comes with its own improvements and flaws. The reviewer should check the following:

• the code is readable
• the code is well tested
• the code is documented (including return types and parameters)
• the code is easy to maintain

Author checklist after completed review

• I have added a line to the CHANGELOG describing this change, in a section
  reflecting type of change (add section where missing):
  • added: when you have added new functionality
  • changed: when default behaviour of the code has been changed
  • fixes: when your contribution fixes a bug

Checklist for assignee

• PR is up to date with the base branch
• the tests pass
• author has added an entry to the changelog (and designated the change as added, changed or fixed)
• Once the PR is ready to be merged, squash commits and merge the PR.

[mfroelund]

Great to fix this:)

[leifdenby]

ok. I think I have fixed the things you commented on @mafdmi :) thank you for the review! I'm really glad you looked at this because I clearly missed some things. Hopefully you think this looks ok now :)

[mfroelund]

Looks great!