Skip to content

Fix chunk size check#59

Merged
observingClouds merged 3 commits intomllam:mainfrom
ealerskans:bugfix/check_chunks
Feb 5, 2025
Merged

Fix chunk size check#59
observingClouds merged 3 commits intomllam:mainfrom
ealerskans:bugfix/check_chunks

Conversation

@ealerskans
Copy link
Contributor

@ealerskans ealerskans commented Feb 3, 2025

Describe your changes

Updates check_chunk_size to use the actual dimensions of the data-array to estimate the memory usage of the chunking. It also corrects the warning print statement. Previously, it was assumed that all variables have the same coordinates, but now the coordinates for each individual variable is used to estimate the size bytes for a chunking of that variable.

No change in dependencies for this fix

Issue Link

Tries to fix #57 .

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 Documentation (Addition or improvements to documentation)

Checklist before requesting a review

  • My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
  • I have performed a self-review of my code
  • For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
  • I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
  • I have updated the documentation to cover introduced code changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have given the PR a name that clearly describes the change, written in imperative form (context).
  • I have requested a reviewer and an assignee (assignee is responsible for merging)

Checklist for reviewers

Each PR comes with its own improvements and flaws. The reviewer should check the following:

  • the code is readable
  • the code is well tested
  • the code is documented (including return types and parameters)
  • the code is easy to maintain

Author checklist after completed review

  • I have added a line to the CHANGELOG describing this change, in a section
    reflecting type of change (add section where missing):
    • added: when you have added new functionality
    • changed: when default behaviour of the code has been changed
    • fixes: when your contribution fixes a bug

Checklist for assignee

  • PR is up to date with the base branch
  • the tests pass
  • author has added an entry to the changelog (and designated the change as added, changed or fixed)
  • Once the PR is ready to be merged, squash commits and merge the PR.

@ealerskans ealerskans added the bug Something isn't working label Feb 3, 2025
@ealerskans ealerskans requested a review from leifdenby February 5, 2025 07:41
Copy link
Member

@leifdenby leifdenby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need a changelog update then this is ready to go! 🚀 🎸

@leifdenby leifdenby self-requested a review February 5, 2025 15:32
Copy link
Member

@leifdenby leifdenby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ready to merge :)

@observingClouds observingClouds merged commit 4299aab into mllam:main Feb 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong number in chunk max size warning

3 participants