Merged
Conversation
leifdenby
approved these changes
Feb 5, 2025
Member
leifdenby
left a comment
There was a problem hiding this comment.
Just need a changelog update then this is ready to go! 🚀 🎸
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updates
check_chunk_sizeto use the actual dimensions of the data-array to estimate the memory usage of the chunking. It also corrects the warning print statement. Previously, it was assumed that all variables have the same coordinates, but now the coordinates for each individual variable is used to estimate the size bytes for a chunking of that variable.No change in dependencies for this fix
Issue Link
Tries to fix #57 .
Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee