Add a check for config file extension before loading#50
Add a check for config file extension before loading#50leifdenby merged 5 commits intomllam:mainfrom
Conversation
|
sorry for the delay @j6k4m8 - I was off ill for a while... 😞 All the tests pass now :) Do you want to update the changelog and we can get this merged in? Remember to add yourself to the list of contributors in |
|
It's probably fair to call this a bug I think. I would be reasonable to assume that the application supports reading both |
|
I'd (very gently) agree that this is a bug, but I think reasonable to just enforce .yaml for now; it's an easy enough fix and I can't imagine a circumstance where someone can't rename a yml file... But of course, happy to add support for yml if you prefer! PS: hope you're feeling better :) |
|
All done! Thanks for your contribution @j6k4m8 🌟 |
Describe your changes
This PR adds a check (per #47) that ensures the config file path ends with .yaml.
Was thinking about adding a
action=...class to the argument, but feels like overkill and this is much more readable. Feedback welcome if you prefer that technique!Issue Link
Closes #47
Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee