Remove f-string from 'name_format' in config examples#35
Merged
joeloskarsson merged 3 commits intomllam:mainfrom Nov 19, 2024
Merged
Remove f-string from 'name_format' in config examples#35joeloskarsson merged 3 commits intomllam:mainfrom
joeloskarsson merged 3 commits intomllam:mainfrom
Conversation
leifdenby
approved these changes
Nov 7, 2024
Member
leifdenby
left a comment
leifdenby
left a comment
There was a problem hiding this comment.
You are a 🌟 @ealerskans for doing this! Looks perfect to me.
Let's wait till the dev meeting next week so we can get this on the roadmap before we merge
Contributor
|
This is now next on the roadmap, so going ahead and merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new datastores functionality in neural-lam mllam/neural-lam#66 assumes that the
name_formatof the features in the config are without the "f"-string.With this addition, the example config and
README.mdin mllam-data-prep removes "f" from thename_formatkey to be consistent with that.