Call validation split 'val' instead of 'validation' in example config#28
Merged
observingClouds merged 3 commits intomllam:mainfrom Oct 30, 2024
Merged
Conversation
Contributor
|
@ealerskans could you change also the examples in the README.md? I guess quite some folks might copy the example directly from there. |
Member
|
Thanks for doing this @ealerskans and @observingClouds ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new datastores functionality in neural-lam mllam/neural-lam#66 assumes that the validation split is called
valrather thanvalidation.With this addition, the example config in
mllam-data-prepusesvalinstead ofvalidationto be consistent with that, as proposed in #24.