Merged
Conversation
added 2 commits
June 25, 2024 23:11
|
Feedback being "Could we try retrieving the recipe title from one of the other elements on the page, and filtering out the pipe (|) and subsequent content from that? I think that would make for more readable recipe titles." - not 100% sure what they mean by this, but this does seem like a reasonable change. It may be a good idea to keep the recipe-title__mobile tag in the find though, makes it a bit more resilient to structure changes. |
Author
|
addressed |
|
looks good |
|
Seems fine to me. We'll probably end up with more feedback to address from the main PR either way, so I'm fine with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i'm not sure if this is addressing the feedback but this simplifies the title method