Skip to content

et_converter: Support Chakra v0.0.4 in text2chakra converter#9

Merged
srinivas212 merged 1 commit intomlcommons:mainfrom
changhai0109:changhai-textconverter-update
Feb 6, 2024
Merged

et_converter: Support Chakra v0.0.4 in text2chakra converter#9
srinivas212 merged 1 commit intomlcommons:mainfrom
changhai0109:changhai-textconverter-update

Conversation

@changhai0109
Copy link
Copy Markdown
Contributor

Summary

Update text converter to use v0.0.4 schema

Test Plan

# Assuming there is a astrasim text input file, like [astrasim]/inputs/workload/ASTRA-sim-1.0/Resnet50_DataParallel.txt
python -m chakra.et_converter.et_converter \
    --input_type Text \
    --input_filename ${ASTRASIM_DIR}/inputs/workload/ASTRA-sim-1.0/Resnet50_DataParallel.txt \
    --output_filename Resnet50_DataParallel \
    --num_dims 1 \
    --num_npus 64 \
    --num_passes 1

@changhai0109 changhai0109 requested a review from a team as a code owner December 12, 2023 00:04
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 12, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@changhai0109 changhai0109 force-pushed the changhai-textconverter-update branch from a92cbaa to 45ea576 Compare January 19, 2024 22:31
@TaekyungHeo TaekyungHeo force-pushed the changhai-textconverter-update branch from 45ea576 to f29c2bd Compare February 6, 2024 15:11
@TaekyungHeo TaekyungHeo changed the title [ETConverter] Update text converter to new schema et_converter: Support Chakra v0.0.4 in text2chakra converter Feb 6, 2024
@TaekyungHeo TaekyungHeo force-pushed the changhai-textconverter-update branch from f29c2bd to 385565b Compare February 6, 2024 15:13
@TaekyungHeo
Copy link
Copy Markdown
Contributor

Looks good to me. I confirmed that the provided test case works.

@TaekyungHeo TaekyungHeo self-requested a review February 6, 2024 19:45
@srinivas212 srinivas212 merged commit 0e9df72 into mlcommons:main Feb 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants