Skip to content

Remove get_start_timestamp_for_gpu_op from trace_linker.py #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srinivas212 merged 1 commit into from
May 23, 2024
Merged

Remove get_start_timestamp_for_gpu_op from trace_linker.py #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 1 addition & 21 deletions src/trace_link/trace_linker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ def find_parent_cpu_op(self, kineto_gpu_op: KinetoOperator) -> Optional[KinetoOp
f"Found CUDA runtime operation '{kineto_runtime_op.name}' for GPU operator '{kineto_gpu_op.name}'."
)

kineto_gpu_op.timestamp = self.get_start_timestamp_for_gpu_op(kineto_gpu_op)
kineto_gpu_op.timestamp = kineto_runtime_op.timestamp

# Find the closest CPU operator that precedes the CUDA runtime operation
parent_cpu_op = self.find_closest_op(kineto_gpu_op, self.sorted_kineto_cpu_ops, kineto_runtime_op.timestamp)
Expand All @@ -576,26 +576,6 @@ def find_parent_cpu_op(self, kineto_gpu_op: KinetoOperator) -> Optional[KinetoOp

return parent_cpu_op

def get_start_timestamp_for_gpu_op(self, kineto_gpu_op: KinetoOperator) -> int:
"""
Determines the start timestamp for a GPU operator from various sources.

Args:
kineto_gpu_op (KinetoOperator): The GPU operator.

Returns:
int: The start timestamp.

Raises:
RuntimeError: If no valid timestamp is found for the GPU operator.
"""
if kineto_gpu_op.external_id in self.kineto_id_cuda_launch_op_map:
cpu_launcher_op = self.kineto_id_cuda_launch_op_map[kineto_gpu_op.external_id]
return cpu_launcher_op.timestamp + cpu_launcher_op.inclusive_dur
if kineto_gpu_op.external_id in self.kineto_id_arrow_op_map:
return self.kineto_id_arrow_op_map[kineto_gpu_op.external_id].timestamp
raise RuntimeError(f"No valid timestamp found for GPU operator: {kineto_gpu_op}")

def find_closest_op(
self, kineto_gpu_op: KinetoOperator, kineto_ops: List[KinetoOperator], ts: int
) -> Optional[KinetoOperator]:
Expand Down