Refactor chakra_converter and Add Tests#61
Merged
srinivas212 merged 7 commits intomainfrom May 15, 2024
Merged
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
992e8e6 to
03f1f8b
Compare
03f1f8b to
10c85e9
Compare
Contributor
Author
|
Converting to draft because I am unsure whether it is acceptable to add a trace as is without using Git LFS. |
srinivas212
approved these changes
May 15, 2024
Contributor
srinivas212
left a comment
There was a problem hiding this comment.
lgtm. discussed offline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
1. Pytests
2. Correlation
2.1 Run trace_link
2.2 Run et_converter
2.3 Results
