fixes is_cpu_op conversion in constructor#60
Merged
srinivas212 merged 1 commit intomlcommons:mainfrom May 15, 2024
Merged
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
AlexandruAntonescuKeysight
force-pushed
the
is_cpu_op_fix
branch
from
d966ec8 to
db779c9
Compare
Contributor
|
@AlexandruAntonescuKeysight merging this PR. We should discuss adding unit tests for C++ code. |
srinivas212
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the
is_cpu_op()method which was always returningfalse, due to awrong conversionin the constructor.is_cpu_op()method is returningbool, but variableis_cpu_op_was of typeuint32_t--> changed it toboolETFeederNodewas being done inuint32_tinstead ofbool--> changed it toboolis_cpu_opattribute is aboolTest Plan
I've tested using
2 different traces, converted them tojsonusingchakra_jsonizerand checked if thevalue returned by is_cpu_op()method for a specific node isthe same with the one from the json.