Changhai etfeeder others attrs by changhai0109 · Pull Request #27 · mlcommons/chakra

changhai0109 · 2024-03-04T20:58:06Z

Summary

Provide an interface for users to read other optional attrs, which is not predefined in ETFeeder.

Additional Notes

Should be after PR #8

github-actions · 2024-03-04T20:58:17Z

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

JoongunPark · 2024-03-05T00:11:00Z

Can we just put all the 'optional' fields in attr and let simulator to check their presence?
Let me send an email to discuss about this.

modified: et_feeder/et_feeder_node.cpp modified: et_feeder/et_feeder_node.h

changhai0109 · 2024-03-08T17:41:53Z

@srinivas212 @TaekyungHeo
Should be ready for review.
Tested with astrasim master branch.

git clone git@github.com:astra-sim/astra-sim.git
cd astra-sim/extern/graph_frontend/chakra
git remote add folk git@github.com:changhai0109/chakra.git
git fetch folk && git checkout changhai-etfeeder-others-attrs-PR
cd ../../..

./build/astra_analytical/build.sh

./runs/example/run.sh

then get following outputs

sys[0] finished, 1082450000 cycles
callback,sys->id=1,tick=1082450000,node->id=428,node->name=COMP_NODE_conv1_BWD_WG
sys[1] finished, 1082450000 cycles
callback,sys->id=2,tick=1082450000,node->id=643,node->name=COMP_NODE_conv1_BWD_WG
sys[2] finished, 1082450000 cycles
callback,sys->id=3,tick=1082450000,node->id=858,node->name=COMP_NODE_conv1_BWD_WG
sys[3] finished, 1082450000 cycles
callback,sys->id=4,tick=1082450000,node->id=1073,node->name=COMP_NODE_conv1_BWD_WG
sys[4] finished, 1082450000 cycles
callback,sys->id=5,tick=1082450000,node->id=1288,node->name=COMP_NODE_conv1_BWD_WG
sys[5] finished, 1082450000 cycles
callback,sys->id=6,tick=1082450000,node->id=1503,node->name=COMP_NODE_conv1_BWD_WG
sys[6] finished, 1082450000 cycles
callback,sys->id=7,tick=1082450000,node->id=1718,node->name=COMP_NODE_conv1_BWD_WG
sys[7] finished, 1082450000 cycles
callback,sys->id=8,tick=1082450000,node->id=1933,node->name=COMP_NODE_conv1_BWD_WG
sys[8] finished, 1082450000 cycles
callback,sys->id=9,tick=1082450000,node->id=2148,node->name=COMP_NODE_conv1_BWD_WG
sys[9] finished, 1082450000 cycles
callback,sys->id=10,tick=1082450000,node->id=2363,node->name=COMP_NODE_conv1_BWD_WG
sys[10] finished, 1082450000 cycles
callback,sys->id=11,tick=1082450000,node->id=2578,node->name=COMP_NODE_conv1_BWD_WG
sys[11] finished, 1082450000 cycles
callback,sys->id=12,tick=1082450000,node->id=2793,node->name=COMP_NODE_conv1_BWD_WG
sys[12] finished, 1082450000 cycles
callback,sys->id=13,tick=1082450000,node->id=3008,node->name=COMP_NODE_conv1_BWD_WG
sys[13] finished, 1082450000 cycles
callback,sys->id=14,tick=1082450000,node->id=3223,node->name=COMP_NODE_conv1_BWD_WG
sys[14] finished, 1082450000 cycles
callback,sys->id=15,tick=1082450000,node->id=3438,node->name=COMP_NODE_conv1_BWD_WG
sys[15] finished, 1082450000 cycles
callback,sys->id=16,tick=1082450000,node->id=3653,node->name=COMP_NODE_conv1_BWD_WG
sys[16] finished, 1082450000 cycles
callback,sys->id=17,tick=1082450000,node->id=3868,node->name=COMP_NODE_conv1_BWD_WG
sys[17] finished, 1082450000 cycles
callback,sys->id=18,tick=1082450000,node->id=4083,node->name=COMP_NODE_conv1_BWD_WG
sys[18] finished, 1082450000 cycles
callback,sys->id=19,tick=1082450000,node->id=4298,node->name=COMP_NODE_conv1_BWD_WG
sys[19] finished, 1082450000 cycles
callback,sys->id=20,tick=1082450000,node->id=4513,node->name=COMP_NODE_conv1_BWD_WG
sys[20] finished, 1082450000 cycles
callback,sys->id=21,tick=1082450000,node->id=4728,node->name=COMP_NODE_conv1_BWD_WG
sys[21] finished, 1082450000 cycles
callback,sys->id=22,tick=1082450000,node->id=4943,node->name=COMP_NODE_conv1_BWD_WG
sys[22] finished, 1082450000 cycles
callback,sys->id=23,tick=1082450000,node->id=5158,node->name=COMP_NODE_conv1_BWD_WG
sys[23] finished, 1082450000 cycles
callback,sys->id=24,tick=1082450000,node->id=5373,node->name=COMP_NODE_conv1_BWD_WG
sys[24] finished, 1082450000 cycles
callback,sys->id=25,tick=1082450000,node->id=5588,node->name=COMP_NODE_conv1_BWD_WG
sys[25] finished, 1082450000 cycles
callback,sys->id=26,tick=1082450000,node->id=5803,node->name=COMP_NODE_conv1_BWD_WG
sys[26] finished, 1082450000 cycles
callback,sys->id=27,tick=1082450000,node->id=6018,node->name=COMP_NODE_conv1_BWD_WG
sys[27] finished, 1082450000 cycles
callback,sys->id=28,tick=1082450000,node->id=6233,node->name=COMP_NODE_conv1_BWD_WG
sys[28] finished, 1082450000 cycles
callback,sys->id=29,tick=1082450000,node->id=6448,node->name=COMP_NODE_conv1_BWD_WG
sys[29] finished, 1082450000 cycles
callback,sys->id=30,tick=1082450000,node->id=6663,node->name=COMP_NODE_conv1_BWD_WG
sys[30] finished, 1082450000 cycles
callback,sys->id=31,tick=1082450000,node->id=6878,node->name=COMP_NODE_conv1_BWD_WG
sys[31] finished, 1082450000 cycles
callback,sys->id=32,tick=1082450000,node->id=7093,node->name=COMP_NODE_conv1_BWD_WG
sys[32] finished, 1082450000 cycles
callback,sys->id=33,tick=1082450000,node->id=7308,node->name=COMP_NODE_conv1_BWD_WG
sys[33] finished, 1082450000 cycles
callback,sys->id=34,tick=1082450000,node->id=7523,node->name=COMP_NODE_conv1_BWD_WG
sys[34] finished, 1082450000 cycles
callback,sys->id=35,tick=1082450000,node->id=7738,node->name=COMP_NODE_conv1_BWD_WG
sys[35] finished, 1082450000 cycles
callback,sys->id=36,tick=1082450000,node->id=7953,node->name=COMP_NODE_conv1_BWD_WG
sys[36] finished, 1082450000 cycles
callback,sys->id=37,tick=1082450000,node->id=8168,node->name=COMP_NODE_conv1_BWD_WG
sys[37] finished, 1082450000 cycles
callback,sys->id=38,tick=1082450000,node->id=8383,node->name=COMP_NODE_conv1_BWD_WG
sys[38] finished, 1082450000 cycles
callback,sys->id=39,tick=1082450000,node->id=8598,node->name=COMP_NODE_conv1_BWD_WG
sys[39] finished, 1082450000 cycles
callback,sys->id=40,tick=1082450000,node->id=8813,node->name=COMP_NODE_conv1_BWD_WG
sys[40] finished, 1082450000 cycles
callback,sys->id=41,tick=1082450000,node->id=9028,node->name=COMP_NODE_conv1_BWD_WG
sys[41] finished, 1082450000 cycles
callback,sys->id=42,tick=1082450000,node->id=9243,node->name=COMP_NODE_conv1_BWD_WG
sys[42] finished, 1082450000 cycles
callback,sys->id=43,tick=1082450000,node->id=9458,node->name=COMP_NODE_conv1_BWD_WG
sys[43] finished, 1082450000 cycles
callback,sys->id=44,tick=1082450000,node->id=9673,node->name=COMP_NODE_conv1_BWD_WG
sys[44] finished, 1082450000 cycles
callback,sys->id=45,tick=1082450000,node->id=9888,node->name=COMP_NODE_conv1_BWD_WG
sys[45] finished, 1082450000 cycles
callback,sys->id=46,tick=1082450000,node->id=10103,node->name=COMP_NODE_conv1_BWD_WG
sys[46] finished, 1082450000 cycles
callback,sys->id=47,tick=1082450000,node->id=10318,node->name=COMP_NODE_conv1_BWD_WG
sys[47] finished, 1082450000 cycles
callback,sys->id=48,tick=1082450000,node->id=10533,node->name=COMP_NODE_conv1_BWD_WG
sys[48] finished, 1082450000 cycles
callback,sys->id=49,tick=1082450000,node->id=10748,node->name=COMP_NODE_conv1_BWD_WG
sys[49] finished, 1082450000 cycles
callback,sys->id=50,tick=1082450000,node->id=10963,node->name=COMP_NODE_conv1_BWD_WG
sys[50] finished, 1082450000 cycles
callback,sys->id=51,tick=1082450000,node->id=11178,node->name=COMP_NODE_conv1_BWD_WG
sys[51] finished, 1082450000 cycles
callback,sys->id=52,tick=1082450000,node->id=11393,node->name=COMP_NODE_conv1_BWD_WG
sys[52] finished, 1082450000 cycles
callback,sys->id=53,tick=1082450000,node->id=11608,node->name=COMP_NODE_conv1_BWD_WG
sys[53] finished, 1082450000 cycles
callback,sys->id=54,tick=1082450000,node->id=11823,node->name=COMP_NODE_conv1_BWD_WG
sys[54] finished, 1082450000 cycles
callback,sys->id=55,tick=1082450000,node->id=12038,node->name=COMP_NODE_conv1_BWD_WG
sys[55] finished, 1082450000 cycles
callback,sys->id=56,tick=1082450000,node->id=12253,node->name=COMP_NODE_conv1_BWD_WG
sys[56] finished, 1082450000 cycles
callback,sys->id=57,tick=1082450000,node->id=12468,node->name=COMP_NODE_conv1_BWD_WG
sys[57] finished, 1082450000 cycles
callback,sys->id=58,tick=1082450000,node->id=12683,node->name=COMP_NODE_conv1_BWD_WG
sys[58] finished, 1082450000 cycles
callback,sys->id=59,tick=1082450000,node->id=12898,node->name=COMP_NODE_conv1_BWD_WG
sys[59] finished, 1082450000 cycles
callback,sys->id=60,tick=1082450000,node->id=13113,node->name=COMP_NODE_conv1_BWD_WG
sys[60] finished, 1082450000 cycles
callback,sys->id=61,tick=1082450000,node->id=13328,node->name=COMP_NODE_conv1_BWD_WG
sys[61] finished, 1082450000 cycles
callback,sys->id=62,tick=1082450000,node->id=13543,node->name=COMP_NODE_conv1_BWD_WG
sys[62] finished, 1082450000 cycles
callback,sys->id=63,tick=1082450000,node->id=13758,node->name=COMP_NODE_conv1_BWD_WG
sys[63] finished, 1082450000 cycles

srinivas212 · 2024-04-02T00:50:00Z

Thanks for these changes, @changhai0109!

changhai0109 force-pushed the changhai-etfeeder-others-attrs-PR branch from 59aa509 to bd8a60f Compare March 7, 2024 20:26

changhai0109 marked this pull request as ready for review March 7, 2024 20:26

changhai0109 requested a review from a team as a code owner March 7, 2024 20:26

changhai0109 force-pushed the changhai-etfeeder-others-attrs-PR branch from bd8a60f to 9dc4d06 Compare March 7, 2024 20:28

[ETFeeder] Added API to get other attrs.

1cff339

modified: et_feeder/et_feeder_node.cpp modified: et_feeder/et_feeder_node.h

changhai0109 force-pushed the changhai-etfeeder-others-attrs-PR branch from 9dc4d06 to 1cff339 Compare March 7, 2024 20:34

srinivas212 approved these changes Apr 2, 2024

View reviewed changes

srinivas212 merged commit a815e0c into mlcommons:main Apr 2, 2024

github-actions bot locked and limited conversation to collaborators Apr 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changhai etfeeder others attrs#27

Changhai etfeeder others attrs#27
srinivas212 merged 1 commit intomlcommons:mainfrom
changhai0109:changhai-etfeeder-others-attrs-PR

changhai0109 commented Mar 4, 2024

Uh oh!

github-actions bot commented Mar 4, 2024 •

edited

Loading

Uh oh!

JoongunPark commented Mar 5, 2024

Uh oh!

changhai0109 commented Mar 8, 2024

Uh oh!

srinivas212 commented Apr 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

changhai0109 commented Mar 4, 2024

Summary

Additional Notes

Uh oh!

github-actions bot commented Mar 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoongunPark commented Mar 5, 2024

Uh oh!

changhai0109 commented Mar 8, 2024

Uh oh!

srinivas212 commented Apr 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Mar 4, 2024 •

edited

Loading