Skip to content

Integrate flake8 and pyre for automated linting and type checking#20

Merged
srinivas212 merged 21 commits intomainfrom
lint
Feb 6, 2024
Merged

Integrate flake8 and pyre for automated linting and type checking#20
srinivas212 merged 21 commits intomainfrom
lint

Conversation

@TaekyungHeo
Copy link
Copy Markdown
Contributor

@TaekyungHeo TaekyungHeo commented Feb 6, 2024

Summary

  • Enabled flake8 and pyre linting.
  • Added automated linting workflow.
  • Fixed flake8 and pyre warnings/errors.

Test Plan

Ran flake8 and pyre.

$ flake8 .
$ pyre check

Ran post-processing steps.

$ cd ~/param
$ cd param/train/comms/pt
$ pip install .
$ cd ../../compute/python
$ pip install -r requirements.txt
$ python setup.py install
$ python tools/trace_link.py --pytorch-et-file ~/llama_pytorch_et/llama_et_0.json --kineto-file ~/llama_kineto/worker0_step_12.1697596714999.pt.trace.json --output-file ~/rank0.json

$ cd ~/charka
$ pip install .
$ python3 -m chakra.et_converter.et_converter --input_type PyTorch --input_filename ~/rank0.json --output_filename ~/rank0.chakra --num_dims 1

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 6, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@TaekyungHeo TaekyungHeo force-pushed the lint branch 10 times, most recently from 37e09a7 to b5e4ddf Compare February 6, 2024 17:50
@TaekyungHeo TaekyungHeo marked this pull request as ready for review February 6, 2024 17:51
@TaekyungHeo TaekyungHeo requested a review from a team as a code owner February 6, 2024 17:51
@TaekyungHeo TaekyungHeo changed the title Introduce Python linting via GitHub actions Integrate flake8 and pyre for automated linting and type checking Feb 6, 2024
@srinivas212 srinivas212 merged commit 120ce3d into main Feb 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
@TaekyungHeo TaekyungHeo deleted the lint branch February 6, 2024 22:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants