Enhance error handling in ETFeeder::lookupNode with detailed exception messages#10
Merged
srinivas212 merged 1 commit intomlcommons:mainfrom Feb 6, 2024
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
a5f7a40 to
84ce1f7
Compare
Contributor
|
Looks good to me. It works. |
srinivas212
approved these changes
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a significant improvement in error handling within the ETFeeder::lookupNode method. By catching and handling std::out_of_range exceptions, the update ensures that any attempt to access a non-existent node ID in the dependency graph is met with a clear and informative error message.
Test Plan