Skip to content

Update Sentiment Analysis Model to version 2.0#43

Merged
shiffman merged 3 commits intomainfrom
model-sentiment-rebased
Sep 17, 2023
Merged

Update Sentiment Analysis Model to version 2.0#43
shiffman merged 3 commits intomainfrom
model-sentiment-rebased

Conversation

@ch3926
Copy link
Collaborator

@ch3926 ch3926 commented Sep 5, 2023

This version is compatible with the main branch and contains a p5 example.

Main Updates:

  • Src is largely unchanged from previous version
  • Imported modelLoader
  • Updated p5 sketch with new functionality
  • Should we pick a more sophisticated model? Currently uses this movie dataset..

- Src is largely unchanged from previous version
- Imported modelLoader
- Updated p5 sketch with new functionality
@gohai gohai mentioned this pull request Sep 6, 2023
@ch3926
Copy link
Collaborator Author

ch3926 commented Sep 12, 2023

@gohai @shiffman This is the new PR for sentiment-analysis. It is currently ready to be merged into main.

Update p5 to 1.6
Add newlines at end of files
Don't use const in examples
Don't use template literals in example
Don't use unneeded === in example
Run prettifier
@gohai
Copy link
Member

gohai commented Sep 16, 2023

Thank you, @ch3926! 🙌 I tested your branch and committed the few odd cleanups.

@shiffman That'd be ready to be merged if we still plan on keeping the sentiment analysis model around.

@shiffman
Copy link
Member

Wonderful, great work @ch3926! Merging! This is a lovely demonstration and example for my class this fall. Tagging in @sproutleaf @QuinnHe @MOQN just to keep you in the loop in terms of documentation for the new website!

@gohai If we end up building more features into ml5.js as they relate to transformer models, I could see us replacing this with a different method, we can continue to discuss!

@shiffman shiffman merged commit c2011e5 into main Sep 17, 2023
@gohai gohai deleted the model-sentiment-rebased branch October 2, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants