Skip to content

Avoid duplicate CI runs when starting a PR from upstream branch#2788

Merged
zcbenz merged 5 commits intomainfrom
ci-fix-dup-runs
Nov 18, 2025
Merged

Avoid duplicate CI runs when starting a PR from upstream branch#2788
zcbenz merged 5 commits intomainfrom
ci-fix-dup-runs

Conversation

@zcbenz
Copy link
Copy Markdown
Collaborator

@zcbenz zcbenz commented Nov 17, 2025

Also makes the check_lint runs faster.

@awni
Copy link
Copy Markdown
Member

awni commented Nov 18, 2025

It's kind of odd how it shows the skipped tests in this case. Maybe it would be cleaner to just restrict push to main?

@zcbenz
Copy link
Copy Markdown
Collaborator Author

zcbenz commented Nov 18, 2025

Yeah it does not look good, I have changed to test main branch only.

@awni
Copy link
Copy Markdown
Member

awni commented Nov 18, 2025

We could add a manual trigger like we have for the release workflow if you want to be able to run the CI on a ml-explore/mlx branch without making a PR.

@awni
Copy link
Copy Markdown
Member

awni commented Nov 18, 2025

Actually the way you have it also works well.

Copy link
Copy Markdown
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zcbenz zcbenz merged commit a9f0d6b into main Nov 18, 2025
10 checks passed
@zcbenz zcbenz deleted the ci-fix-dup-runs branch November 18, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants