Use std::optional for mask_arr arg#2763
Merged
zcbenz merged 1 commit intoml-explore:mainfrom Nov 17, 2025
Merged
Conversation
Member
|
My understanding is this was an intentional design choice to enable masks which require more than one array in the future. CC @jagrit06 or @angeloskath might have an example of that? If not then yea we should simplify it. |
Member
|
Yeah I think Jagrit had a specific thing in mind but I am pro simplifying now and breaking the API later. |
awni
approved these changes
Nov 16, 2025
Member
awni
left a comment
awni
left a comment
There was a problem hiding this comment.
LGTM, we can change it back in the future if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the API and kernel only support one mask so there is no need to store masks in a std::vector.