Compatibility with pip-installed openmpi#2741
Merged
angeloskath merged 7 commits intoml-explore:mainfrom Nov 8, 2025
Merged
Conversation
pcuenca
commented
Nov 7, 2025
Contributor
Author
|
If this solution is acceptable, I can tweak the docs a bit. |
Contributor
|
Does this suggest that instead of |
Contributor
Author
|
This works with |
Contributor
Author
|
As updated in the initial description, I tested the following combinations:
|
angeloskath
approved these changes
Nov 7, 2025
Member
angeloskath
left a comment
There was a problem hiding this comment.
Thanks! This looks great!
I 'll merge after the tests clear.
Member
|
Some random thought. Perhaps we should change the environment variable to |
Contributor
Author
Good call, thank you! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When installing openmpi using
pipin a virtual environment, the installation looks like this (incomplete):However,
mpi.cppuses a hardcoded name,libmpi.dylib, todlopen(). The installation does not provide a symlink.On the Python side,
distributed_runwas already special-casing homebrew installations by explicitly passingDYLD_LIBRARY_PATHtompirun. This PR:DYLD_LIBRARY_PATHis sent in all cases, as long as an mpi library is found.ompi_infowithotool. Other common tools, such asmpirun, are not linked against the shared library.mpi.cppto use.This should result in a more robust environment detection and increased compatibility.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changesManual Tests
conda install openmpi;conda install conda-forge::openmpidid not put anmpirunexecutable anywhere in my environment)