Conversation
.github/workflows/release.yml
Outdated
| outputs: | ||
| pypi_env: ${{ github.event_name == 'push' && 'pypi' || 'test-pypi' }} | ||
| pypi_url: ${{ github.event_name == 'push' && 'https://upload.pypi.org/legacy/' || 'https://test.pypi.org/legacy/' }} | ||
| pypi_dups: ${{ github.event_name == 'push' && 'true' || 'false' }} |
There was a problem hiding this comment.
I'm a bit confused by this variable. How is it used to determine if there is already a package of the same name on pypi?
There was a problem hiding this comment.
I actually got it backwards! When we are publishing to pypi (on a tag pushed event) we want to fail on duplicates, when publishing to test-pypi (on a manual workflow launch event) it's fine to skip when there are duplicates.
For regular releases there shouldn't be duplicates, but for the test releases since we're not incrementing the version number in between then the releases could be repeating (until we delete them I guess?)
|
I'm pretty sure the failure at https://github.com/ml-explore/mlx/actions/runs/19140474034/job/54704171529 is not related to this change set, but I don't know if it is a hardware issue or machine setup issue or just a flaky test. |
|
I agree that failure seems unrelated. Very strange. Those kinds of failures that only happen on circle are almost impossible to debug without ssh access :( |
|
For GitHub-hosted runners people can use https://github.com/mxschmitt/action-tmate to ssh into the machine. Not sure if it is usable for self-hosted runners or whether Apple's policy allows it. |
3 participants
Proposed changes
Print hashes when uploading to PyPI
Skip already existing artifacts for Test-PyPI
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes