Migrate CircleCI to GitHub Actions#2716
Conversation
Co-authored-by: Joseph Heck <[email protected]>
| # - name: Publish package distributions to PyPI | ||
| # uses: pypa/gh-action-pypi-publish@release/v1 |
There was a problem hiding this comment.
Note that this will not publish to pypi yet, we will have to do that as a second commit after the workflows exist and we can configure trusted publishing.
| # Compatibility matrix: https://docs.nvidia.com/deeplearning/cudnn/backend/latest/reference/support-matrix.html | ||
| # This also drops `nvcc` into `/usr/local/cuda-12.9/bin/nvcc` - but it's *not* on the default PATH | ||
|
|
||
| - name: Package and Driver Report |
There was a problem hiding this comment.
This is not required, but was useful during debugging when setting up the workflows and has low cost to keeping it in.
| - name: Build macOS 13 package | ||
| if: inputs.build-type == 'release' | ||
| uses: ./.github/actions/build-macos-release | ||
| with: | ||
| macos-target: 13.0 | ||
| - name: Build macOS 14 package | ||
| if: inputs.build-type == 'release' | ||
| uses: ./.github/actions/build-macos-release | ||
| with: | ||
| macos-target: 14.0 | ||
| - name: Build macOS 15 package | ||
| if: inputs.build-type == 'release' | ||
| uses: ./.github/actions/build-macos-release | ||
| with: | ||
| macos-target: 15.0 No newline at end of file |
There was a problem hiding this comment.
We can't embed a matrix inside of a job so manually specify the combinations in series. It's not that many so it's probably ok to maintain this for now.
| @@ -0,0 +1,6 @@ | |||
| version: 2 | |||
| updates: | |||
There was a problem hiding this comment.
python ecosystem maybe deserves to be here as well
| - name: setup python venv | ||
| shell: bash | ||
| run: | | ||
| python -m venv .venv | ||
| source .venv/bin/activate | ||
| echo PATH=$PATH >> $GITHUB_ENV | ||
| pip install --upgrade pip cmake |
There was a problem hiding this comment.
We used system python and added the venv directly to the path because cmake was having issues deciding whether to look at system or uv and it was getting too messy to configure it otherwise.
awni
left a comment
awni
left a comment
There was a problem hiding this comment.
Looks good. Let's merge it and iterate.
2 participants
Proposed changes
Port over the CircleCI configuration to equivalent GitHub Actions configuration.