Fix KeyError for missing domain_uuid_key in Thunderbolt setup#2682
Merged
angeloskath merged 1 commit intoml-explore:mainfrom Oct 30, 2025
Merged
Conversation
- Check for None before accessing domain_uuid_key and skip invalid entries - Filter items to only those with domain_uuid_key before extracting connection - Prevents KeyError when thunderbolt topology data is incomplete
angeloskath
approved these changes
Oct 30, 2025
Member
angeloskath
left a comment
There was a problem hiding this comment.
Thanks looks and works great.
Contributor
|
Thanks! I was experiencing this recently! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes a
KeyErrorinmlx.distributedwhen setting up Thunderbolt ring topology.The error occurred when
domain_uuid_keywas missing from Thunderbolt topology data, which happens when certain devices (such as external monitors) are connected to the Mac. The code attempted to access this key without first checking for its presence.This PR adds validation to check for
domain_uuid_keybefore accessing it and filters topology items to only those with valid keys, preventing the crash when the topology data is incomplete.Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes