Fix fast synch when fence is waited before a command buffer is created#2657
Merged
Fix fast synch when fence is waited before a command buffer is created#2657
Conversation
Member
Author
|
The test case would be something like: import mlx.core as mx
def fun():
return mx.squeeze(mx.array([1.0]), stream=mx.cpu) + mx.array(1.0)
mx.synchronize() # should commit active command buffers
print(fun()) |
angeloskath
approved these changes
Oct 8, 2025
Member
angeloskath
left a comment
angeloskath
left a comment
There was a problem hiding this comment.
Awesome! I am glad this ended up being an easy fix.
faisalmemon
pushed a commit
to faisalmemon/mlx
that referenced
this pull request
Oct 30, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title.
I didn't add a test for this because we don't test the fast synch yet (maybe we should?)..